Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1726223008: Hide GrPipelineBuilder from GrOvalRenderer (Closed)

Created:
4 years, 10 months ago by robertphillips
Modified:
4 years, 10 months ago
Reviewers:
joshualitt, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Hide GrPipelineBuilder from GrOvalRenderer Limiting the reach of GrPipelineBuilder is always good. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726223008 Committed: https://skia.googlesource.com/skia/+/b56f92783a5d84347b65f4f01ec3668096649d13

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -69 lines) Patch
M src/gpu/GrDrawContext.cpp View 4 chunks +39 lines, -40 lines 0 comments Download
M src/gpu/GrOvalRenderer.h View 2 chunks +5 lines, -8 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 3 chunks +3 lines, -21 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
4 years, 10 months ago (2016-02-25 17:36:13 UTC) #4
joshualitt
On 2016/02/25 17:36:13, robertphillips wrote: lgtm
4 years, 10 months ago (2016-02-25 18:19:13 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726223008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726223008/1
4 years, 10 months ago (2016-02-25 18:41:24 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-25 19:00:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726223008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726223008/1
4 years, 10 months ago (2016-02-25 19:02:57 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 19:03:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b56f92783a5d84347b65f4f01ec3668096649d13

Powered by Google App Engine
This is Rietveld 408576698