Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 1726213004: Deduplicate axis value resolving code. (Closed)

Created:
4 years, 9 months ago by bungeman-skia
Modified:
4 years, 9 months ago
Reviewers:
dogben, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Deduplicate axis value resolving code. The code was originally written for Android, but is now implemented more generally by the FreeType scanner to be shared between all FreeType backed typefaces. This removes the now duplicate code in the Android font manager and uses the shared code instead. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726213004 Committed: https://skia.googlesource.com/skia/+/47a1e96b957b50662274360f1a390d76ab3d02cc

Patch Set 1 #

Patch Set 2 : Don't change the API, make debugging easier. #

Patch Set 3 : Convince gcc that the values are assigned before use. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -60 lines) Patch
M src/ports/SkFontMgr_android.cpp View 1 chunk +3 lines, -43 lines 0 comments Download
M src/ports/SkFontMgr_android_parser.h View 2 chunks +2 lines, -7 lines 0 comments Download
M src/ports/SkFontMgr_android_parser.cpp View 1 2 3 chunks +21 lines, -9 lines 0 comments Download
M tests/FontMgrAndroidParserTest.cpp View 1 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 28 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726213004/1
4 years, 9 months ago (2016-02-24 20:41:32 UTC) #3
bungeman-skia
This is something of setup for (and modification to) https://codereview.chromium.org/1709403003 . In other words, let's ...
4 years, 9 months ago (2016-02-24 21:17:49 UTC) #7
bungeman-skia
mtklein should also look at this, since I haven't sent any other code removal changes ...
4 years, 9 months ago (2016-02-24 21:20:58 UTC) #9
dogben
lgtm
4 years, 9 months ago (2016-02-25 00:52:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726213004/1
4 years, 9 months ago (2016-02-25 01:58:50 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/6888)
4 years, 9 months ago (2016-02-25 02:00:05 UTC) #14
mtklein
lgtm
4 years, 9 months ago (2016-02-25 02:01:09 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726213004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726213004/20001
4 years, 9 months ago (2016-02-25 18:46:52 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/6541)
4 years, 9 months ago (2016-02-25 18:48:54 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726213004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726213004/40001
4 years, 9 months ago (2016-02-25 18:54:01 UTC) #21
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-25 19:12:47 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726213004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726213004/40001
4 years, 9 months ago (2016-02-25 19:19:18 UTC) #26
commit-bot: I haz the power
4 years, 9 months ago (2016-02-25 19:20:05 UTC) #28
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/47a1e96b957b50662274360f1a390d76ab3d02cc

Powered by Google App Engine
This is Rietveld 408576698