Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1709403003: Check scalar to fixed conversions with axes. (Closed)

Created:
4 years, 10 months ago by dogben
Modified:
4 years, 10 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Check scalar to fixed conversions with axes. In SkTypeface_FreeType::Scanner::computeAxisValues, check for out-of-range values before converting to SkFixed. BUG=skia:4632 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1709403003 Committed: https://skia.googlesource.com/skia/+/64a3c95e93f863a220b56e1264553ca518e5a0e9

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 1 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709403003/1
4 years, 10 months ago (2016-02-19 18:27:29 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-19 18:50:18 UTC) #5
dogben
4 years, 10 months ago (2016-02-19 18:52:58 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709403003/20001
4 years, 10 months ago (2016-02-25 19:41:34 UTC) #9
bungeman-skia
lgtm
4 years, 10 months ago (2016-02-25 19:54:11 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-25 19:56:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709403003/20001
4 years, 10 months ago (2016-02-25 20:19:54 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 20:20:43 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/64a3c95e93f863a220b56e1264553ca518e5a0e9

Powered by Google App Engine
This is Rietveld 408576698