Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 1726193002: EME: Remove all references to `needkey` except the UMA name. (Closed)

Created:
4 years, 10 months ago by ddorwin
Modified:
4 years, 10 months ago
Reviewers:
xhwang, pfeldman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, blink-reviews, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

EME: Remove all references to `needkey` except the UMA name. The `needkey` event from the prefixed API has been replaced by `encrypted`. We continue to use the UMA name, though. Also removes some event names I missed in the previous CL. BUG=249976 Committed: https://crrev.com/301ccdb3cfef6992faa0d4ac95f4d748116eecec Cr-Commit-Position: refs/heads/master@{#377471}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M content/renderer/media/android/webmediaplayer_android.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/formats/webm/webm_stream_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M media/test/data/eme_player_js/player_utils.js View 1 chunk +0 lines, -4 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventTypeNames.in View 1 chunk +0 lines, -4 lines 2 comments Download

Messages

Total messages: 22 (10 generated)
ddorwin
A bit more cleanup.
4 years, 10 months ago (2016-02-23 23:23:22 UTC) #3
xhwang
lgtm
4 years, 10 months ago (2016-02-24 00:44:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726193002/1
4 years, 10 months ago (2016-02-24 00:45:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/149364)
4 years, 10 months ago (2016-02-24 01:12:02 UTC) #8
ddorwin
pfeldman: Please OWHERS review the simple removal from the Blink file.
4 years, 10 months ago (2016-02-24 16:52:05 UTC) #10
pfeldman
lgtm https://codereview.chromium.org/1726193002/diff/1/third_party/WebKit/Source/core/events/EventTypeNames.in File third_party/WebKit/Source/core/events/EventTypeNames.in (left): https://codereview.chromium.org/1726193002/diff/1/third_party/WebKit/Source/core/events/EventTypeNames.in#oldcode259 third_party/WebKit/Source/core/events/EventTypeNames.in:259: webkitkeyadded I assume these are all EME?
4 years, 10 months ago (2016-02-24 22:09:29 UTC) #11
ddorwin
https://codereview.chromium.org/1726193002/diff/1/third_party/WebKit/Source/core/events/EventTypeNames.in File third_party/WebKit/Source/core/events/EventTypeNames.in (left): https://codereview.chromium.org/1726193002/diff/1/third_party/WebKit/Source/core/events/EventTypeNames.in#oldcode259 third_party/WebKit/Source/core/events/EventTypeNames.in:259: webkitkeyadded On 2016/02/24 22:09:28, pfeldman wrote: > I assume ...
4 years, 10 months ago (2016-02-24 22:19:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726193002/1
4 years, 10 months ago (2016-02-24 22:20:45 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/121097)
4 years, 10 months ago (2016-02-24 23:01:48 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1726193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1726193002/1
4 years, 10 months ago (2016-02-25 00:17:10 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 02:39:26 UTC) #20
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 02:40:25 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/301ccdb3cfef6992faa0d4ac95f4d748116eecec
Cr-Commit-Position: refs/heads/master@{#377471}

Powered by Google App Engine
This is Rietveld 408576698