Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2177)

Unified Diff: content/renderer/media/android/webmediaplayer_android.cc

Issue 1726193002: EME: Remove all references to `needkey` except the UMA name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/android/webmediaplayer_android.cc
diff --git a/content/renderer/media/android/webmediaplayer_android.cc b/content/renderer/media/android/webmediaplayer_android.cc
index 8616d130ecd3bc34babc7abfb46d8b07e9def461..059e96f580aefb94ae56d870a2acdd12869bfb93 100644
--- a/content/renderer/media/android/webmediaplayer_android.cc
+++ b/content/renderer/media/android/webmediaplayer_android.cc
@@ -84,8 +84,6 @@ using media::MediaPlayerAndroid;
using media::VideoFrame;
namespace {
-// Prefix for histograms related to Encrypted Media Extensions.
-const char* kMediaEme = "Media.EME.";
// Values for Media.Android.IsHttpLiveStreamingMediaPredictionResult UMA.
// Never reuse values!
@@ -1490,7 +1488,8 @@ void WebMediaPlayerAndroid::OnEncryptedMediaInitData(
return;
}
- UMA_HISTOGRAM_COUNTS(kMediaEme + std::string("NeedKey"), 1);
+ // TODO(xhwang): Update this UMA name. https://crbug.com/589251
+ UMA_HISTOGRAM_COUNTS("Media.EME.NeedKey", 1);
DCHECK(init_data_type != media::EmeInitDataType::UNKNOWN);
« no previous file with comments | « no previous file | media/blink/webmediaplayer_impl.cc » ('j') | third_party/WebKit/Source/core/events/EventTypeNames.in » ('J')

Powered by Google App Engine
This is Rietveld 408576698