Issue 17261025: The order of the generated supplemental code is not guaranteed

Issue 17261025: The order of the generated supplemental code is not guaranteed (Closed)

Created:
7 years, 6 months ago by do-not-use

Modified:
7 years, 6 months ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, lgombos

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

The order of the generated supplemental code is not guaranteed Sort the supplemental idl files before generating the code so that it is generated in a consistent order. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152836

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added a comment #

Patch Set 3 : Add a comment #

Patch Set 4 : Add a comment #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	Source/bindings/scripts/generate-bindings.pl	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM https://codereview.chromium.org/17261025/diff/1/Source/bindings/scripts/generate-bindings.pl File Source/bindings/scripts/generate-bindings.pl (right): https://codereview.chromium.org/17261025/diff/1/Source/bindings/scripts/generate-bindings.pl#newcode100 Source/bindings/scripts/generate-bindings.pl:100: @supplementedIdlFiles = sort @followingIdlFiles; Would you add a ...

7 years, 6 months ago (2013-06-20 15:08:29 UTC) #3

do-not-use

On 2013/06/20 15:08:29, haraken wrote: > LGTM > > https://codereview.chromium.org/17261025/diff/1/Source/bindings/scripts/generate-bindings.pl > File Source/bindings/scripts/generate-bindings.pl (right): > ...

7 years, 6 months ago (2013-06-20 20:08:33 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17261025/10001

7 years, 6 months ago (2013-06-20 22:35:50 UTC) #6

Message was sent while issue was closed.

Change committed as 152836

Expand Messages | Collapse Messages