Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: Source/bindings/scripts/generate-bindings.pl

Issue 17261025: The order of the generated supplemental code is not guaranteed (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add a comment Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/generate-bindings.pl
diff --git a/Source/bindings/scripts/generate-bindings.pl b/Source/bindings/scripts/generate-bindings.pl
index 4be15c16d8132447f77b7d6415b5ffae8db47f9c..734042932fa952d983f127c66256f1f3f1c521e1 100755
--- a/Source/bindings/scripts/generate-bindings.pl
+++ b/Source/bindings/scripts/generate-bindings.pl
@@ -97,7 +97,9 @@ if ($supplementalDependencyFile) {
my ($idlFile, @followingIdlFiles) = split(/\s+/, $line);
if ($idlFile and basename($idlFile) eq basename($targetIdlFile)) {
$idlFound = 1;
- @supplementedIdlFiles = @followingIdlFiles;
+ # We sort the supplemental IDL files so that the corresponding code is generated
+ # in a consistent order. This is important for the bindings tests.
+ @supplementedIdlFiles = sort @followingIdlFiles;
}
}
close FH;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698