Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 1725793003: Update 4f linear gradient selection heuristic (Closed)

Created:
4 years, 10 months ago by f(malita)
Modified:
4 years, 10 months ago
Reviewers:
herb_g, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update 4f linear gradient selection heuristic Use the 4f context when * dest type is 4f * there's no perpective Keeping the define and testing flag overrides for now. R=reed@google.com,herb@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1725793003 Committed: https://skia.googlesource.com/skia/+/55430a620762e882c2b3018c57f9a7d51cf16071

Patch Set 1 #

Patch Set 2 : rename override define #

Patch Set 3 : update Color4f_shader test #

Patch Set 4 : spelling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -16 lines) Patch
M src/effects/gradients/SkLinearGradient.cpp View 1 3 chunks +14 lines, -7 lines 0 comments Download
M tests/SkColor4fTest.cpp View 1 2 3 2 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
f(malita)
This lets us test 4f gradients in SampleApp by switching to S32/F16.
4 years, 10 months ago (2016-02-23 14:39:27 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725793003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725793003/20001
4 years, 10 months ago (2016-02-23 14:40:01 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/6405)
4 years, 10 months ago (2016-02-23 14:52:05 UTC) #6
reed1
Knowing that the blitter still might call shadeSpan4f() even if this picks the old subclass, ...
4 years, 10 months ago (2016-02-23 15:43:34 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725793003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725793003/40001
4 years, 10 months ago (2016-02-23 18:08:24 UTC) #9
f(malita)
I had to relax the Color4f_shader unit test tolerance to accommodate the new version, PTAL. ...
4 years, 10 months ago (2016-02-23 18:19:46 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725793003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725793003/60001
4 years, 10 months ago (2016-02-23 18:21:25 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-23 18:36:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725793003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725793003/60001
4 years, 10 months ago (2016-02-23 21:25:29 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 21:26:32 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/55430a620762e882c2b3018c57f9a7d51cf16071

Powered by Google App Engine
This is Rietveld 408576698