Revert to Immersive Fullscreen on OSX for a multimonitors

Revert to Immersive Fullscreen on OSX for a special case

If the user is using multiple monitors and turned off "Separate Space
in Each Display", use Immersive Fullscreen so that the other monitors
won't blank out.

BUG=582944, 580843
Committed: https://crrev.com/d310f829e7f38f725a5b695ea701a3ffa3b3cf89
Cr-Commit-Position: refs/heads/master@{#377116}

[spqchan, 2016-02-23 18:15:01]

Description was changed from

==========
Revert to Immersive Fullscreen on OSX for a special case

If the user is using multiple monitors and turned off "Separate Space
in Each Display", use Immersive Fullscreen so that the other monitors
won't blank out.

BUG=582944,580843
==========

to

==========
Revert to Immersive Fullscreen on OSX for a special case

If the user is using multiple monitors and turned off "Separate Space
in Each Display", use Immersive Fullscreen so that the other monitors
won't blank out.

BUG=582944,580843
==========

[spqchan, 2016-02-23 18:17:00]

spqchan@chromium.org changed reviewers:
+ avi@chromium.org

[spqchan, 2016-02-23 18:17:01]

PTAL

[Avi (use Gerrit), 2016-02-23 20:15:59]

I haven't been paying attention to the discussion. Is this what the Mac team has
decided on?

https://codereview.chromium.org/1725643002/diff/1/chrome/browser/ui/cocoa/bro...
File chrome/browser/ui/cocoa/browser_window_controller.mm (right):

https://codereview.chromium.org/1725643002/diff/1/chrome/browser/ui/cocoa/bro...
chrome/browser/ui/cocoa/browser_window_controller.mm:2019: BOOL
hasMultipleMonitors = [[NSScreen screens] count] > 1;
Does this trigger with mirrored displays? Do we want it to?

https://codereview.chromium.org/1725643002/diff/1/chrome/browser/ui/cocoa/bro...
chrome/browser/ui/cocoa/browser_window_controller.mm:2027: !(hasMultipleMonitors
&& ![NSScreen screensHaveSeparateSpaces]))
This if() needs {}s because the condition has multiple lines.

[spqchan, 2016-02-23 21:27:59]

Yes, I brought the discussion to Product and UX and it's decided on
giving this scenario the exception so that the video fullscreen is usable.

https://codereview.chromium.org/1725643002/diff/1/chrome/browser/ui/cocoa/bro...
File chrome/browser/ui/cocoa/browser_window_controller.mm (right):

https://codereview.chromium.org/1725643002/diff/1/chrome/browser/ui/cocoa/bro...
chrome/browser/ui/cocoa/browser_window_controller.mm:2019: BOOL
hasMultipleMonitors = [[NSScreen screens] count] > 1;
On 2016/02/23 20:15:59, Avi wrote:
> Does this trigger with mirrored displays? Do we want it to?

Good point on the mirrored displays. This should trigger when we have multiple
distinct displays.
Anyway, I just tested it with mirror displays and it seems to work fine.
However, I noticed that screen.h has a NumOfDisplays() method which gives you
the number of
distinct displays and decided to switch into that just to be safe.

https://codereview.chromium.org/1725643002/diff/1/chrome/browser/ui/cocoa/bro...
chrome/browser/ui/cocoa/browser_window_controller.mm:2027: !(hasMultipleMonitors
&& ![NSScreen screensHaveSeparateSpaces]))
On 2016/02/23 20:15:59, Avi wrote:
> This if() needs {}s because the condition has multiple lines.

Done.

[Avi (use Gerrit), 2016-02-23 21:47:52]

lgtm

[spqchan, 2016-02-23 21:50:49]

The CQ bit was checked by spqchan@chromium.org

[commit-bot: I haz the power, 2016-02-23 21:54:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1725643002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1725643002/20001

[commit-bot: I haz the power, 2016-02-23 23:22:19]

Description was changed from

==========
Revert to Immersive Fullscreen on OSX for a special case

If the user is using multiple monitors and turned off "Separate Space
in Each Display", use Immersive Fullscreen so that the other monitors
won't blank out.

BUG=582944,580843
==========

to

==========
Revert to Immersive Fullscreen on OSX for a special case

If the user is using multiple monitors and turned off "Separate Space
in Each Display", use Immersive Fullscreen so that the other monitors
won't blank out.

BUG=582944,580843
==========

[commit-bot: I haz the power, 2016-02-23 23:22:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-23 23:24:24]

Description was changed from

==========
Revert to Immersive Fullscreen on OSX for a special case

If the user is using multiple monitors and turned off "Separate Space
in Each Display", use Immersive Fullscreen so that the other monitors
won't blank out.

BUG=582944,580843
==========

to

==========
Revert to Immersive Fullscreen on OSX for a special case

If the user is using multiple monitors and turned off "Separate Space
in Each Display", use Immersive Fullscreen so that the other monitors
won't blank out.

BUG=582944,580843

Committed: https://crrev.com/d310f829e7f38f725a5b695ea701a3ffa3b3cf89
Cr-Commit-Position: refs/heads/master@{#377116}
==========

[commit-bot: I haz the power, 2016-02-23 23:24:24]

Patchset 2 (id:??) landed as
https://crrev.com/d310f829e7f38f725a5b695ea701a3ffa3b3cf89
Cr-Commit-Position: refs/heads/master@{#377116}