Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1725583002: Work in progress to make //ios/chrome/browser build again in GN. (Closed)

Created:
4 years, 10 months ago by Dirk Pranke
Modified:
4 years, 9 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_ios_hack_2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Work in progress to make //ios/chrome/browser build again in GN. Currently the code pulls in dependencies on VP8, jingle, and various other things that look like they've crept in. This is my work-in-progress patch to fix the issues. THIS PATCH IS NOT YET READY FOR LANDING. R=sdefresne@chromium.org BUG=459705

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -17 lines) Patch
M components/autofill/core/browser/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M components/invalidation/impl/BUILD.gn View 3 chunks +6 lines, -3 lines 0 comments Download
A + ios/chrome/app/resources/BUILD.gn View 1 chunk +5 lines, -4 lines 0 comments Download
M ios/chrome/browser/BUILD.gn View 5 chunks +11 lines, -6 lines 0 comments Download
M ios/public/provider/chrome/browser/BUILD.gn View 1 chunk +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (1 generated)
Dirk Pranke
4 years, 10 months ago (2016-02-23 01:00:33 UTC) #1
sdefresne
On 2016/02/23 at 01:00:33, dpranke wrote: > Thank you for sharing this work in progress. ...
4 years, 10 months ago (2016-02-23 09:58:46 UTC) #2
Dirk Pranke
On 2016/02/23 09:58:46, sdefresne wrote: > On 2016/02/23 at 01:00:33, dpranke wrote: > > > ...
4 years, 10 months ago (2016-02-23 19:01:28 UTC) #3
Dirk Pranke
On 2016/02/23 19:01:28, Dirk Pranke wrote: > On 2016/02/23 09:58:46, sdefresne wrote: > > On ...
4 years, 9 months ago (2016-03-16 23:12:21 UTC) #4
sdefresne
On 2016/03/16 at 23:12:21, dpranke wrote: > On 2016/02/23 19:01:28, Dirk Pranke wrote: > > ...
4 years, 9 months ago (2016-03-17 09:40:45 UTC) #5
Dirk Pranke
4 years, 9 months ago (2016-03-18 02:18:20 UTC) #6
On 2016/03/17 09:40:45, sdefresne wrote:
> My flurry of CLs has not yet fully obsoleted this CL, but you can close it if
> you want, I'll cherry-pick the remaining missing bits.

Okay, I'll leave it open for now in case I find time to get to it tomorrow, but
feel free to close it if you take care of this first.

Powered by Google App Engine
This is Rietveld 408576698