Remove the 'ios_use_webrtc' build flag hack.

Remove the 'ios_use_webrtc' build flag hack.

For a time we needed to enable (parts of) the WebRTC GN build
on iOS, because there was an indirect dependency on WebRTC in
order for some components to be able to depend on xmllite.
Those components have since been switched to depend on libxml2,
and so there is no reason for Chromium to build WebRTC on iOS
now (though WebRTC is free to build on iOS on its own).

This CL cleans up the build configs accordingly.

R=brettw@chromium.org, kjellander@chromium.org, sdefresne@chromium.org
BUG=538497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.mac:ios_rel_device_gn,ios_dbg_simulator_gn

Committed: https://crrev.com/0e5462ce39fd05b41ec66850f473ac6327284409
Cr-Commit-Position: refs/heads/master@{#377070}

[kjellander_chromium, 2016-02-22 04:23:40]

https://codereview.chromium.org/1718073002/diff/1/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/1718073002/diff/1/BUILD.gn#oldcode211
BUILD.gn:211: "//ios/chrome:ios_chrome_unittests",
Shouldn't these be added by default now then?

[Dirk Pranke, 2016-02-22 04:34:27]

https://codereview.chromium.org/1718073002/diff/1/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/1718073002/diff/1/BUILD.gn#oldcode211
BUILD.gn:211: "//ios/chrome:ios_chrome_unittests",
On 2016/02/22 04:23:40, kjellander (chromium) wrote:
> Shouldn't these be added by default now then?

Ooo, good catch. I had thought that they might already be pulled in by other
targets, but I suspect you're
right and they aren't. I will add them in and see.

[Dirk Pranke, 2016-02-22 04:35:10]

Description was changed from

==========
Remove the 'ios_use_webrtc' build flag hack.

For a time we needed to enable (parts of) the WebRTC GN build
on iOS, because there was an indirect dependency on WebRTC in
order for some components to be able to depend on xmllite.
Those components have since been switched to depend on libxml2,
and so there is no reason for Chromium to build WebRTC on iOS
now (though WebRTC is free to build on iOS on its own).

This CL cleans up the build configs accordingly.

R=brettw@chromium.org, kjellander@chromium.org, sdefresne@chromium.org
BUG=538497
==========

to

==========
Remove the 'ios_use_webrtc' build flag hack.

For a time we needed to enable (parts of) the WebRTC GN build
on iOS, because there was an indirect dependency on WebRTC in
order for some components to be able to depend on xmllite.
Those components have since been switched to depend on libxml2,
and so there is no reason for Chromium to build WebRTC on iOS
now (though WebRTC is free to build on iOS on its own).

This CL cleans up the build configs accordingly.

R=brettw@chromium.org, kjellander@chromium.org, sdefresne@chromium.org
BUG=538497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.mac:ios_rel_device_gn,ios_dbg_simulator_gn
==========

[kjellander_chromium, 2016-02-22 05:26:52]

lgtm, assuming you figure out the current build errors.

https://codereview.chromium.org/1718073002/diff/1/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/1718073002/diff/1/BUILD.gn#oldcode211
BUILD.gn:211: "//ios/chrome:ios_chrome_unittests",
On 2016/02/22 04:34:27, Dirk Pranke wrote:
> On 2016/02/22 04:23:40, kjellander (chromium) wrote:
> > Shouldn't these be added by default now then?
> 
> Ooo, good catch. I had thought that they might already be pulled in by other
> targets, but I suspect you're
> right and they aren't. I will add them in and see.

Just to be clear: I didn't analyze if they were, but I checked that they weren't
at least present in src/BUILD.gn.

[sdefresne, 2016-02-22 09:18:12]

Apparently some dependency on //content crept in in one of the components :-(
The good thing is that it soon should be an error with gyp too.

lgtm once the //content dependency has been sorted out

[Dirk Pranke, 2016-02-22 22:52:30]

On 2016/02/22 09:18:12, sdefresne wrote:
> Apparently some dependency on //content crept in in one of the components :-(
> The good thing is that it soon should be an error with gyp too.
> 
> lgtm once the //content dependency has been sorted out

It looks like //ios/chrome/browser ends up pulling in several dependencies with
non-trivial fixes,
so I'd consider getting that target to work out of scope for this CL.

Given that those binaries weren't being built by default before, I don't think
it's much of a 
regression to build them by default now, and I would rather simplify the build
files to 
not have this hack,  but I can see how someone working on the iOS port might
rather 
focus effort elsewhere.

For now I'll remove those targets from the top-level build and post an update.

sdefresne, let me know what you think.

[brettw, 2016-02-22 22:59:47]

lgtm

[Dirk Pranke, 2016-02-22 23:02:06]

I've posted the work-in-progress stuff I was doing to try and get the other iOS
targets to build in 
https://codereview.chromium.org/1725583002/ , if that's helpful.

Sylvain, please take another look?

[sdefresne, 2016-02-23 09:48:22]

lgtm, I'll take care of //ios/chrome targets ...

[Dirk Pranke, 2016-02-23 19:01:33]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2016-02-23 19:01:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1718073002/#ps40001
(title: "fix string_provider reference and comment out other ios targets for
now")

[commit-bot: I haz the power, 2016-02-23 19:06:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1718073002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1718073002/40001

[commit-bot: I haz the power, 2016-02-23 19:57:56]

Description was changed from

==========
Remove the 'ios_use_webrtc' build flag hack.

For a time we needed to enable (parts of) the WebRTC GN build
on iOS, because there was an indirect dependency on WebRTC in
order for some components to be able to depend on xmllite.
Those components have since been switched to depend on libxml2,
and so there is no reason for Chromium to build WebRTC on iOS
now (though WebRTC is free to build on iOS on its own).

This CL cleans up the build configs accordingly.

R=brettw@chromium.org, kjellander@chromium.org, sdefresne@chromium.org
BUG=538497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.mac:ios_rel_device_gn,ios_dbg_simulator_gn
==========

to

==========
Remove the 'ios_use_webrtc' build flag hack.

For a time we needed to enable (parts of) the WebRTC GN build
on iOS, because there was an indirect dependency on WebRTC in
order for some components to be able to depend on xmllite.
Those components have since been switched to depend on libxml2,
and so there is no reason for Chromium to build WebRTC on iOS
now (though WebRTC is free to build on iOS on its own).

This CL cleans up the build configs accordingly.

R=brettw@chromium.org, kjellander@chromium.org, sdefresne@chromium.org
BUG=538497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.mac:ios_rel_device_gn,ios_dbg_simulator_gn
==========

[commit-bot: I haz the power, 2016-02-23 19:57:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-23 19:59:04]

Description was changed from

==========
Remove the 'ios_use_webrtc' build flag hack.

For a time we needed to enable (parts of) the WebRTC GN build
on iOS, because there was an indirect dependency on WebRTC in
order for some components to be able to depend on xmllite.
Those components have since been switched to depend on libxml2,
and so there is no reason for Chromium to build WebRTC on iOS
now (though WebRTC is free to build on iOS on its own).

This CL cleans up the build configs accordingly.

R=brettw@chromium.org, kjellander@chromium.org, sdefresne@chromium.org
BUG=538497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.mac:ios_rel_device_gn,ios_dbg_simulator_gn
==========

to

==========
Remove the 'ios_use_webrtc' build flag hack.

For a time we needed to enable (parts of) the WebRTC GN build
on iOS, because there was an indirect dependency on WebRTC in
order for some components to be able to depend on xmllite.
Those components have since been switched to depend on libxml2,
and so there is no reason for Chromium to build WebRTC on iOS
now (though WebRTC is free to build on iOS on its own).

This CL cleans up the build configs accordingly.

R=brettw@chromium.org, kjellander@chromium.org, sdefresne@chromium.org
BUG=538497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.mac:ios_rel_device_gn,ios_dbg_simulator_gn

Committed: https://crrev.com/0e5462ce39fd05b41ec66850f473ac6327284409
Cr-Commit-Position: refs/heads/master@{#377070}
==========

[commit-bot: I haz the power, 2016-02-23 19:59:05]

Patchset 3 (id:??) landed as
https://crrev.com/0e5462ce39fd05b41ec66850f473ac6327284409
Cr-Commit-Position: refs/heads/master@{#377070}