Issue 1725573003: Change presubmit lint check to a blacklist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1725573003: Change presubmit lint check to a blacklist. (Closed)

Created:
4 years, 10 months ago by dsinclair

Modified:
4 years, 10 months ago

Reviewers:
Tom Sepez, Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Change presubmit lint check to a blacklist. This CL changes the possible lint flags to a blacklist which can be burned down. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d2019df0a77c5d01a336f16be054d2f373e38c54

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -3 lines)			Patch
	M	PRESUBMIT.py	View		1 chunk	+36 lines, -2 lines	0 comments	Download
	M	testing/fx_string_testhelpers.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

dsinclair

Committed patchset #2 (id:20001) manually as d2019df0a77c5d01a336f16be054d2f373e38c54 (presubmit successful).

4 years, 10 months ago (2016-02-23 03:32:04 UTC) #5

Lei Zhang

4 years, 10 months ago (2016-02-23 04:31:39 UTC) #6

Message was sent while issue was closed.

BTW, the author field on this is your personal account.