Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: PRESUBMIT.py

Issue 1725573003: Change presubmit lint check to a blacklist. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Rebase to master Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | testing/fx_string_testhelpers.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for pdfium. 5 """Presubmit script for pdfium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
11 LINT_FILTERS = [ 11 LINT_FILTERS = [
12 '-', 12 '-build/c++11',
13 '+build/header_guard', 13 '-build/include',
14 '-build/include_order',
15 '-build/include_what_you_use',
16 '-build/namespaces',
17 '-build/storage_class',
18 '-readability/braces',
19 '-readability/casting',
20 '-readability/fn_size',
21 '-readability/function',
22 '-readability/inheritance',
23 '-readability/multiline_comment',
24 '-readability/multiline_string',
25 '-readability/namespace',
26 '-readability/todo',
27 '-readability/utf8',
28 '-runtime/arrays',
29 '-runtime/casting',
30 '-runtime/explicit',
31 '-runtime/int',
32 '-runtime/printf',
33 '-runtime/references',
34 '-runtime/threadsafe_fn',
35 '-whitespace/blank_line',
36 '-whitespace/braces',
37 '-whitespace/comments',
38 '-whitespace/end_of_line',
39 '-whitespace/ending_newline',
40 '-whitespace/indent',
41 '-whitespace/line_length',
42 '-whitespace/newline',
43 '-whitespace/operators',
44 '-whitespace/parens',
45 '-whitespace/semicolon',
46 '-whitespace/tab',
47 '-whitespace/todo',
14 ] 48 ]
15 49
16 def CheckChangeOnUpload(input_api, output_api): 50 def CheckChangeOnUpload(input_api, output_api):
17 results = [] 51 results = []
18 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api) 52 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)
19 results += input_api.canned_checks.CheckChangeLintsClean( 53 results += input_api.canned_checks.CheckChangeLintsClean(
20 input_api, output_api, None, LINT_FILTERS) 54 input_api, output_api, None, LINT_FILTERS)
21 return results 55 return results
OLDNEW
« no previous file with comments | « no previous file | testing/fx_string_testhelpers.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698