MD user manager (learn more page, user manager tutorial)

MD user manager (learn more page, user manager tutorial)

Part 3 of https://codereview.chromium.org/1630903002/

BUG=563722
Committed: https://crrev.com/94428289996176d91c07d9c99764586190417470
Cr-Commit-Position: refs/heads/master@{#384074}

[Moe, 2016-02-23 00:12:26]

Description was changed from

==========
MD user manager (learn more page, user manager tutorial)

Part 3 of https://codereview.chromium.org/1630903002/

based on https://codereview.chromium.org/1722843002/

BUG=563722
==========

to

==========
MD user manager (learn more page, user manager tutorial)

Part 3 of https://codereview.chromium.org/1630903002/

based on https://codereview.chromium.org/1722843002/

BUG=563722
==========

[Moe, 2016-02-23 00:12:26]

mahmadi@chromium.org changed reviewers:
+ dbeam@chromium.org

[Moe, 2016-02-23 00:13:10]

Here's part 3 of https://codereview.chromium.org/1630903002/

[Dan Beam, 2016-02-25 17:22:08]

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_user_manager/user_manager.js (right):

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_user_manager/user_manager.js:51: if (hash && hash ==
'#tutorial')
why is this code better than

  if (window.location.hash == '#tutorial')

?

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_user_manager/user_manager_tutorial.html
(right):

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_user_manager/user_manager_tutorial.html:8: <div
hidden$="{{hidden}}">
you should probably use dom-if for large amounts of hidden UI

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_user_manager/user_manager_tutorial.html:72: <a
is="action-link" on-tap="handleAddUser_"
nit: everywhere else (downloads, settings, history) we've been doing something
along the lines of:

<element id=blah on-tap="onBlahTap_">

as in: on<ID><action>_

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_user_manager/user_manager_tutorial.js (right):

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_user_manager/user_manager_tutorial.js:17: * True if
the tutorial is currently showing.
this is confusing.  did you mean "hidden" instead of showing?  what about
"Whether this tutorial should be visible." or something?  conversely, you could
reverse this to a property named "showing"

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_user_manager/user_manager_tutorial.js:20: hidden: {
can you use a different name?

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_user_manager/user_manager_tutorial.js:41: 'notYou'];
this.steps_ = ['yourChrome', 'friends', 'guests', 'complete', 'notYou'];

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_user_manager/user_manager_tutorial.js:91: var podRow
= /** @type {{focusPod: !function(), pods: !Array}} */
you should be casting to the generated polymer element type and depending on the
other element in your compiled_resources2.gyp (so it can get type info)

the transformation done by --polymer_pass is (for example) user-manager-tutorial
-> UserManagerTutorialElement

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_user_manager/user_manager_tutorial.js:109:
this.hidden = true;
yeah, there's already a .hidden setter on HTMLElement, which is why this is
confusing (you're probably shadowing it)

[Moe, 2016-03-02 18:25:53]

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_user_manager/user_manager.js (right):

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_user_manager/user_manager.js:51: if (hash && hash ==
'#tutorial')
On 2016/02/25 17:22:07, Dan Beam wrote:
> why is this code better than
> 
>   if (window.location.hash == '#tutorial')
> 
> ?

The check is unnecessary. I agree. I reintroduced the old js code that used to
be here. But I know that doesn't mean I shouldn't make sure it makes sense :)

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_user_manager/user_manager_tutorial.html
(right):

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_user_manager/user_manager_tutorial.html:8: <div
hidden$="{{hidden}}">
On 2016/02/25 17:22:07, Dan Beam wrote:
> you should probably use dom-if for large amounts of hidden UI

I like your suggestion. But when I use dom-if i run into this problem that i18n
content don't get processed when an element is inside a dom-if that evaluates to
false which seems like an expected side effect. If the element isn't attached to
the DOM we can't expect i18n content to be scanned and processed. How do you
solve that problem?

I'm having the same problem with create_profile.html which I noticed now and I'm
reverting in this patch.

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_user_manager/user_manager_tutorial.html:72: <a
is="action-link" on-tap="handleAddUser_"
On 2016/02/25 17:22:07, Dan Beam wrote:
> nit: everywhere else (downloads, settings, history) we've been doing something
> along the lines of:
> 
> <element id=blah on-tap="onBlahTap_">
> 
> as in: on<ID><action>_

+1. Done.

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_user_manager/user_manager_tutorial.js (right):

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_user_manager/user_manager_tutorial.js:17: * True if
the tutorial is currently showing.
On 2016/02/25 17:22:07, Dan Beam wrote:
> this is confusing.  did you mean "hidden" instead of showing?  what about
> "Whether this tutorial should be visible." or something?  conversely, you
could
> reverse this to a property named "showing"

Done.

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_user_manager/user_manager_tutorial.js:20: hidden: {
On 2016/02/25 17:22:07, Dan Beam wrote:
> can you use a different name?

In the patch set #2 I've changed this to "hidden_" which is the standard I've
been following elsewhere for private properties.

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_user_manager/user_manager_tutorial.js:41: 'notYou'];
On 2016/02/25 17:22:07, Dan Beam wrote:
> this.steps_ = ['yourChrome', 'friends', 'guests', 'complete', 'notYou'];

Done.

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_user_manager/user_manager_tutorial.js:91: var podRow
= /** @type {{focusPod: !function(), pods: !Array}} */
On 2016/02/25 17:22:07, Dan Beam wrote:
> you should be casting to the generated polymer element type and depending on
the
> other element in your compiled_resources2.gyp (so it can get type info)
> 
> the transformation done by --polymer_pass is (for example)
user-manager-tutorial
> -> UserManagerTutorialElement

unfortunately 'pod-row' is not a polymer element at the moment. Also the
comments in the source don't seem to be properly formatted for closure compiler
and there's no compiled_resources.gyp or compiled_resources2.gyp for it or its
dependencies.

https://codereview.chromium.org/1725563003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_user_manager/user_manager_tutorial.js:109:
this.hidden = true;
On 2016/02/25 17:22:07, Dan Beam wrote:
> yeah, there's already a .hidden setter on HTMLElement, which is why this is
> confusing (you're probably shadowing it)

I've renamed this to hidden_

[Moe, 2016-03-03 18:54:50]

https://codereview.chromium.org/1725563003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_user_manager/user_manager.html (right):

https://codereview.chromium.org/1725563003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_user_manager/user_manager.html:11: <link
rel="stylesheet" href="chrome://resources/css/chrome_shared.css">
Added this back because it was breaking the hyperlink's default color.

[Moe, 2016-03-04 00:41:21]

figured out the dom-if template and i18n-content issue and updated the html to
used dom-if template.

[Dan Beam, 2016-03-15 02:24:55]

overall, I think this code is looking mighty fine

I have not seen followup tests since this[1].  how are they coming?

[1] https://codereview.chromium.org/1722843002#msg18

https://codereview.chromium.org/1725563003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_user_manager/supervised_user_learn_more.js
(right):

https://codereview.chromium.org/1725563003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_user_manager/supervised_user_learn_more.js:10: *
@element supervised-user-learn-more
fyi: we've dropped all the @element tags from settings

https://codereview.chromium.org/1725563003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_user_manager/user_manager.html (right):

https://codereview.chromium.org/1725563003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_user_manager/user_manager.html:11: <link
rel="stylesheet" href="chrome://resources/css/chrome_shared.css">
On 2016/03/03 18:54:50, Moe wrote:
> Added this back because it was breaking the hyperlink's default color.

please compose out the link styles to avoid including this

https://codereview.chromium.org/1725563003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_user_manager/user_manager_tutorial.html
(right):

https://codereview.chromium.org/1725563003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_user_manager/user_manager_tutorial.html:9: <div
hidden$="{{hidden_}}">
any time you're trying to hide a large amount of UI, use dom-if

https://codereview.chromium.org/1725563003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/md_user_manager/user_manager_tutorial.html
(right):

https://codereview.chromium.org/1725563003/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_user_manager/user_manager_tutorial.html:11:
<template is="dom-if" if="[[!isStepHidden_(currentStep_, 'yourChrome')]]">
it's better not to copy constants here, if possible (i.e. store 'yourChrome' in
an enum or constant aliased on |this| so that you can use it here)

https://codereview.chromium.org/1725563003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/md_user_manager/user_manager_tutorial.js (right):

https://codereview.chromium.org/1725563003/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_user_manager/user_manager_tutorial.js:90: var podRow
= /** @type {{focusPod: !function(), pods: !Array}} */
is there a @type that you could use (and a js dependency that you could add to
your compiled_resources2.gyp) here other so we don't have to copy parts of
pod-row's API?

https://codereview.chromium.org/1725563003/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_user_manager/user_manager_tutorial.js:96: }
nit:

  var singlePod = podRow.pods.length == 1;
  this.$.yourChrome.classList.toggle('single-pod', singlePod);
  this.$.complete.classList.toggle('single-pod', singlePod);

[Dan Beam, 2016-03-15 02:25:39]

https://codereview.chromium.org/1725563003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_user_manager/user_manager_tutorial.html
(right):

https://codereview.chromium.org/1725563003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_user_manager/user_manager_tutorial.html:9: <div
hidden$="{{hidden_}}">
On 2016/03/15 02:24:55, Dan Beam wrote:
> any time you're trying to hide a large amount of UI, use dom-if

nvm, i think you did this proactively (thanks!)

[Moe, 2016-03-22 23:34:57]

Hi Dan, sent out (cl/1819773004) for the tests. will write tests for the old
handlers that didn't have tests as well.

https://codereview.chromium.org/1725563003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_user_manager/supervised_user_learn_more.js
(right):

https://codereview.chromium.org/1725563003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_user_manager/supervised_user_learn_more.js:10: *
@element supervised-user-learn-more
On 2016/03/15 02:24:55, Dan Beam wrote:
> fyi: we've dropped all the @element tags from settings

Done.

https://codereview.chromium.org/1725563003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_user_manager/user_manager.html (right):

https://codereview.chromium.org/1725563003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_user_manager/user_manager.html:11: <link
rel="stylesheet" href="chrome://resources/css/chrome_shared.css">
On 2016/03/15 02:24:55, Dan Beam wrote:
> On 2016/03/03 18:54:50, Moe wrote:
> > Added this back because it was breaking the hyperlink's default color.
> 
> please compose out the link styles to avoid including this

Done.

https://codereview.chromium.org/1725563003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/md_user_manager/user_manager_tutorial.html
(right):

https://codereview.chromium.org/1725563003/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_user_manager/user_manager_tutorial.html:11:
<template is="dom-if" if="[[!isStepHidden_(currentStep_, 'yourChrome')]]">
On 2016/03/15 02:24:55, Dan Beam wrote:
> it's better not to copy constants here, if possible (i.e. store 'yourChrome'
in
> an enum or constant aliased on |this| so that you can use it here)

Done.

https://codereview.chromium.org/1725563003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/md_user_manager/user_manager_tutorial.js (right):

https://codereview.chromium.org/1725563003/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_user_manager/user_manager_tutorial.js:96: }
On 2016/03/15 02:24:55, Dan Beam wrote:
> nit:
> 
>   var singlePod = podRow.pods.length == 1;
>   this.$.yourChrome.classList.toggle('single-pod', singlePod);
>   this.$.complete.classList.toggle('single-pod', singlePod);

Done.

[Dan Beam, 2016-03-25 02:39:15]

lgtm w/nits

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
File chrome/browser/resources/md_user_manager/supervised_user_learn_more.css
(right):

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
chrome/browser/resources/md_user_manager/supervised_user_learn_more.css:7: };
}; -> }

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
File chrome/browser/resources/md_user_manager/user_manager.css (right):

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
chrome/browser/resources/md_user_manager/user_manager.css:6: in this file. */
you probably need to import this file in user_manager.html or somewhere before
this code
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/polyme...

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
File chrome/browser/resources/md_user_manager/user_manager_tutorial.css (right):

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
chrome/browser/resources/md_user_manager/user_manager_tutorial.css:23:
margin-left: 30px;
-webkit-margin-start: 30px; instead?

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
File chrome/browser/resources/md_user_manager/user_manager_tutorial.html
(right):

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
chrome/browser/resources/md_user_manager/user_manager_tutorial.html:76: <img
src="chrome://theme/IDR_CLOSE_1">
any reason why you're not using an <iron-icon icon="close"> here instead?

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
File chrome/browser/resources/md_user_manager/user_manager_tutorial.js (right):

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
chrome/browser/resources/md_user_manager/user_manager_tutorial.js:37: * @private
{!Object<string, string>}
nit: only strings can be object keys in js, so this is equivalent to:

  * @private {!Object<string>}

however, I think you should make an enum instead

(function() {

/** @enum {string} */
var TutorialSteps = {
  YOUR_CHROME: 'yourChrome',
  FRIENDS: 'friends',
  GUESTS: 'guests',
  COMPLETE: 'complete',
  NOT_YOU: 'notYou',
};

...

Polymer({
  ...
  properties: {
    steps_: {
      type: Object,
      value: TutorialSteps,
    },
  }
...
});

}());

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
chrome/browser/resources/md_user_manager/user_manager_tutorial.js:95: var podRow
= /** @type {{focusPod: !function(), pods: !Array}} */
i still think this is a bummer to cast to instead of a real element's API

[Moe, 2016-03-29 18:54:39]

Thank you Dan!

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
File chrome/browser/resources/md_user_manager/supervised_user_learn_more.css
(right):

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
chrome/browser/resources/md_user_manager/supervised_user_learn_more.css:7: };
On 2016/03/25 02:39:14, Dan Beam wrote:
> }; -> }

Oops. Done.

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
File chrome/browser/resources/md_user_manager/user_manager.css (right):

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
chrome/browser/resources/md_user_manager/user_manager.css:6: in this file. */
On 2016/03/25 02:39:14, Dan Beam wrote:
> you probably need to import this file in user_manager.html or somewhere before
> this code
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/polyme...

Importing color.html doesn't seem to fix it by itself. color.html declares the
color variables on :root inside a <style is="custom-style"> element. That
apparently works differently from declaring those variables on :root in a plain
css file (you can see that when inspecting the page). Variables declared that
way seem to only work if they're used inside a <style is="custom-style"> element
in the main document or within a Polymer component. The solution I came up with
was to refactor this css file into a Polymer style module and using it like
this:
<style is="custom-style" include="user-manager-styles"></style>

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
File chrome/browser/resources/md_user_manager/user_manager_tutorial.css (right):

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
chrome/browser/resources/md_user_manager/user_manager_tutorial.css:23:
margin-left: 30px;
On 2016/03/25 02:39:14, Dan Beam wrote:
> -webkit-margin-start: 30px; instead?

Done.

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
File chrome/browser/resources/md_user_manager/user_manager_tutorial.html
(right):

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
chrome/browser/resources/md_user_manager/user_manager_tutorial.html:76: <img
src="chrome://theme/IDR_CLOSE_1">
On 2016/03/25 02:39:14, Dan Beam wrote:
> any reason why you're not using an <iron-icon icon="close"> here instead?

Done! No good reason. I had forgotten to change it when "Polymerizing" the
existing tutorial HTML.

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
File chrome/browser/resources/md_user_manager/user_manager_tutorial.js (right):

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
chrome/browser/resources/md_user_manager/user_manager_tutorial.js:37: * @private
{!Object<string, string>}
On 2016/03/25 02:39:14, Dan Beam wrote:
> nit: only strings can be object keys in js, so this is equivalent to:
> 
>   * @private {!Object<string>}
> 
> however, I think you should make an enum instead
> 
> (function() {
> 
> /** @enum {string} */
> var TutorialSteps = {
>   YOUR_CHROME: 'yourChrome',
>   FRIENDS: 'friends',
>   GUESTS: 'guests',
>   COMPLETE: 'complete',
>   NOT_YOU: 'notYou',
> };
> 
> ...
> 
> Polymer({
>   ...
>   properties: {
>     steps_: {
>       type: Object,
>       value: TutorialSteps,
>     },
>   }
> ...
> });
> 
> }());

Done.

https://codereview.chromium.org/1725563003/diff/120001/chrome/browser/resourc...
chrome/browser/resources/md_user_manager/user_manager_tutorial.js:95: var podRow
= /** @type {{focusPod: !function(), pods: !Array}} */
On 2016/03/25 02:39:14, Dan Beam wrote:
> i still think this is a bummer to cast to instead of a real element's API

I agree. I did try adding a compiled_resources2.gyp target for user_pod_row and
including it as a dependency. Unfortunately it doesn't really compile with the
closure compiler (due to bad annotation and missing dependencies) and I'm afraid
fixing it might require a lot of work.

[Moe, 2016-03-29 20:39:46]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2016-03-29 20:39:46]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1725563003/#ps140001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-03-29 20:40:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1725563003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1725563003/140001

[commit-bot: I haz the power, 2016-03-29 20:47:27]

Description was changed from

==========
MD user manager (learn more page, user manager tutorial)

Part 3 of https://codereview.chromium.org/1630903002/

based on https://codereview.chromium.org/1722843002/

BUG=563722
==========

to

==========
MD user manager (learn more page, user manager tutorial)

Part 3 of https://codereview.chromium.org/1630903002/

based on https://codereview.chromium.org/1722843002/

BUG=563722
==========

[commit-bot: I haz the power, 2016-03-29 20:47:28]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-03-29 20:50:16]

Description was changed from

==========
MD user manager (learn more page, user manager tutorial)

Part 3 of https://codereview.chromium.org/1630903002/

based on https://codereview.chromium.org/1722843002/

BUG=563722
==========

to

==========
MD user manager (learn more page, user manager tutorial)

Part 3 of https://codereview.chromium.org/1630903002/

based on https://codereview.chromium.org/1722843002/

BUG=563722

Committed: https://crrev.com/e99ec407569d40709ee036fd218e174ccdced70e
Cr-Commit-Position: refs/heads/master@{#383811}
==========

[commit-bot: I haz the power, 2016-03-29 20:50:17]

Patchset 8 (id:??) landed as
https://crrev.com/e99ec407569d40709ee036fd218e174ccdced70e
Cr-Commit-Position: refs/heads/master@{#383811}

[Moe, 2016-03-30 18:47:21]

Description was changed from

==========
MD user manager (learn more page, user manager tutorial)

Part 3 of https://codereview.chromium.org/1630903002/

based on https://codereview.chromium.org/1722843002/

BUG=563722

Committed: https://crrev.com/e99ec407569d40709ee036fd218e174ccdced70e
Cr-Commit-Position: refs/heads/master@{#383811}
==========

to

==========
MD user manager (learn more page, user manager tutorial)

Part 3 of https://codereview.chromium.org/1630903002/

based on https://codereview.chromium.org/1722843002/

BUG=563722

Committed: https://crrev.com/e99ec407569d40709ee036fd218e174ccdced70e
Cr-Commit-Position: refs/heads/master@{#383811}
==========

[Moe, 2016-03-30 18:47:39]

Description was changed from

==========
MD user manager (learn more page, user manager tutorial)

Part 3 of https://codereview.chromium.org/1630903002/

based on https://codereview.chromium.org/1722843002/

BUG=563722

Committed: https://crrev.com/e99ec407569d40709ee036fd218e174ccdced70e
Cr-Commit-Position: refs/heads/master@{#383811}
==========

to

==========
MD user manager (learn more page, user manager tutorial)

Part 3 of https://codereview.chromium.org/1630903002/

BUG=563722
==========

[Moe, 2016-03-30 18:53:47]

On 2016/03/29 20:50:17, commit-bot: I haz the power wrote:
> Patchset 8 (id:??) landed as
> https://crrev.com/e99ec407569d40709ee036fd218e174ccdced70e
> Cr-Commit-Position: refs/heads/master@{#383811}

Hi Dan,

This was reverted yesterday by the sheriff for breaking browser tests despite
having passed the try bots.

https://codereview.chromium.org/1842703004/

The cause was an extra placeholder in IDS_LEGACY_SUPERVISED_USER_LEARN_MORE_TEXT
which is still being used in the old settings page. I added a new string
IDS_SUPERVISED_USER_LEARN_MORE_TEXT and confirmed those tests don't break
anymore. I will be sending this to the CQ again.

[Moe, 2016-03-30 20:11:24]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2016-03-30 20:11:25]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1725563003/#ps160001
(title: "Fixed what was breaking browser test accross all platforms")

[commit-bot: I haz the power, 2016-03-30 20:12:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1725563003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1725563003/160001

[commit-bot: I haz the power, 2016-03-30 20:18:12]

Description was changed from

==========
MD user manager (learn more page, user manager tutorial)

Part 3 of https://codereview.chromium.org/1630903002/

BUG=563722
==========

to

==========
MD user manager (learn more page, user manager tutorial)

Part 3 of https://codereview.chromium.org/1630903002/

BUG=563722
==========

[commit-bot: I haz the power, 2016-03-30 20:18:14]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-03-30 20:19:18]

Description was changed from

==========
MD user manager (learn more page, user manager tutorial)

Part 3 of https://codereview.chromium.org/1630903002/

BUG=563722
==========

to

==========
MD user manager (learn more page, user manager tutorial)

Part 3 of https://codereview.chromium.org/1630903002/

BUG=563722

Committed: https://crrev.com/94428289996176d91c07d9c99764586190417470
Cr-Commit-Position: refs/heads/master@{#384074}
==========

[commit-bot: I haz the power, 2016-03-30 20:19:20]

Patchset 9 (id:??) landed as
https://crrev.com/94428289996176d91c07d9c99764586190417470
Cr-Commit-Position: refs/heads/master@{#384074}