chrome/browser/resources/md_user_manager/user_manager_tutorial.html - Issue 1725563003: MD user manager (learn more page, user manager tutorial)

Side by Side Diff: chrome/browser/resources/md_user_manager/user_manager_tutorial.html

Issue 1725563003: MD user manager (learn more page, user manager tutorial) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/md_user_manager/user_manager.js ('K') | « chrome/browser/resources/md_user_manager/user_manager_tutorial.css ('k') | chrome/browser/resources/md_user_manager/user_manager_tutorial.js » ('j') | chrome/browser/resources/md_user_manager/user_manager_tutorial.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

	3

	4 <dom-module id="user-manager-tutorial">

	5 <link rel="import" type="css"

	6 href="chrome://md-user-manager/user_manager_tutorial.css">

	7 <template>

	8 <div hidden$="{{hidden}}">
	Dan Beam 2016/02/25 17:22:07 you should probably use dom-if for large amounts o you should probably use dom-if for large amounts of hidden UI Moe 2016/03/02 18:25:52 I like your suggestion. But when I use dom-if i ru Show quoted text On 2016/02/25 17:22:07, Dan Beam wrote: > you should probably use dom-if for large amounts of hidden UI I like your suggestion. But when I use dom-if i run into this problem that i18n content don't get processed when an element is inside a dom-if that evaluates to false which seems like an expected side effect. If the element isn't attached to the DOM we can't expect i18n content to be scanned and processed. How do you solve that problem? I'm having the same problem with create_profile.html which I noticed now and I'm reverting in this patch.
	9 <div class="tutorial-slide" id="yourChrome"

	10 hidden$="{{isStepHidden_(currentStep_, 'yourChrome')}}">

	11 <div class="slide-image"></div>

	12 <div class="slide-contents">

	13 <div class="slide-title" i18n-content="slideYourChromeTitle"></div>

	14 <div class="slide-text" i18n-content="slideYourChromeText"></div>

	15 </div>

	16 <div class="slide-buttons">

	17 <paper-button on-tap="next_" i18n-content="tutorialNext">

	18 </paper-button>

	19 </div>

	20 </div>

	21

	22 <div class="tutorial-slide" id="guests"

	23 hidden$="{{isStepHidden_(currentStep_, 'guests')}}">

	24 <div class="slide-image"></div>

	25 <div class="slide-contents">

	26 <div class="slide-title" i18n-content="slideGuestsTitle"></div>

	27 <div class="slide-text" i18n-content="slideGuestsText"></div>

	28 </div>

	29 <div class="slide-buttons">

	30 <paper-button on-tap="next_" i18n-content="tutorialNext">

	31 </paper-button>

	32 </div>

	33 <div class="arrow-down"></div>

	34 </div>

	35

	36 <div class="tutorial-slide" id="friends"

	37 hidden$="{{isStepHidden_(currentStep_, 'friends')}}">

	38 <div class="slide-image"></div>

	39 <div class="slide-contents">

	40 <div class="slide-title" i18n-content="slideFriendsTitle"></div>

	41 <div class="slide-text" i18n-content="slideFriendsText"></div>

	42 </div>

	43 <div class="slide-buttons">

	44 <paper-button on-tap="next_" i18n-content="tutorialNext">

	45 </paper-button>

	46 </div>

	47 <div class="arrow-down"></div>

	48 </div>

	49

	50 <div class="tutorial-slide" id="complete"

	51 hidden$="{{isStepHidden_(currentStep_, 'complete')}}">

	52 <div class="slide-image"></div>

	53 <div class="slide-contents">

	54 <div class="slide-title" i18n-content="slideCompleteTitle"></div>

	55 <div class="slide-text" i18n-content="slideCompleteText"></div>

	56 </div>

	57 <div class="slide-buttons">

	58 <paper-button on-tap="next_" i18n-content="tutorialDone">

	59 </paper-button>

	60 </div>

	61 </div>

	62

	63 <div class="tutorial-slide" id="notYou"

	64 hidden$="{{isStepHidden_(currentStep_, 'notYou')}}">

	65 <paper-button id="dismiss-bubble-button" on-tap="endTutorial_">

	66 <img src="chrome://theme/IDR_CLOSE_1">

	67 </paper-button>

	68 <div class="slide-buttons">

	69 <div class="slide-text" i18n-content="slideCompleteUserNotFound">

	70 </div>

	71 <div id="slide-add-user">

	72 <a is="action-link" on-tap="handleAddUser_"
	Dan Beam 2016/02/25 17:22:07 nit: everywhere else (downloads, settings, history nit: everywhere else (downloads, settings, history) we've been doing something along the lines of: <element id=blah on-tap="onBlahTap_"> as in: on<ID><action>_ Moe 2016/03/02 18:25:52 +1. Done. Show quoted text On 2016/02/25 17:22:07, Dan Beam wrote: > nit: everywhere else (downloads, settings, history) we've been doing something > along the lines of: > > <element id=blah on-tap="onBlahTap_"> > > as in: on<ID><action>_ +1. Done.
	73 i18n-content="slideCompleteAddUser"></a>

	74 </div>

	75 </div>

	76 <div class="arrow-down"></div>

	77 </div>

	78 </div>

	79 </template>

	80 <script src="chrome://md-user-manager/user_manager_tutorial.js"></script>

	81 </dom-module>

OLD	NEW