Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: ios/chrome/browser/experimental_flags.mm

Issue 1725533004: Enable iPad Tab Switcher by default on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comment. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/chrome/browser/BUILD.gn ('k') | ios/chrome/browser/snapshots/OWNERS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file can be empty. Its purpose is to contain the relatively short lived 5 // This file can be empty. Its purpose is to contain the relatively short lived
6 // definitions required for experimental flags. 6 // definitions required for experimental flags.
7 7
8 #include "ios/chrome/browser/experimental_flags.h" 8 #include "ios/chrome/browser/experimental_flags.h"
9 9
10 #include <dispatch/dispatch.h> 10 #include <dispatch/dispatch.h>
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 89
90 bool IsTabSwitcherEnabled() { 90 bool IsTabSwitcherEnabled() {
91 // Check if the experimental flag is forced on or off. 91 // Check if the experimental flag is forced on or off.
92 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess(); 92 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
93 if (command_line->HasSwitch(switches::kEnableTabSwitcher)) { 93 if (command_line->HasSwitch(switches::kEnableTabSwitcher)) {
94 return true; 94 return true;
95 } else if (command_line->HasSwitch(switches::kDisableTabSwitcher)) { 95 } else if (command_line->HasSwitch(switches::kDisableTabSwitcher)) {
96 return false; 96 return false;
97 } 97 }
98 98
99 // Check if the finch experiment is turned on. 99 // Check if the finch experiment is turned off.
100 std::string group_name = base::FieldTrialList::FindFullName("IOSTabSwitcher"); 100 std::string group_name = base::FieldTrialList::FindFullName("IOSTabSwitcher");
101 return base::StartsWith(group_name, "Enabled", 101 return !base::StartsWith(group_name, "Disabled",
102 base::CompareCase::INSENSITIVE_ASCII); 102 base::CompareCase::INSENSITIVE_ASCII);
103 } 103 }
104 104
105 bool IsReadingListEnabled() { 105 bool IsReadingListEnabled() {
106 return [[NSUserDefaults standardUserDefaults] boolForKey:kEnableReadingList]; 106 return [[NSUserDefaults standardUserDefaults] boolForKey:kEnableReadingList];
107 } 107 }
108 108
109 } // namespace experimental_flags 109 } // namespace experimental_flags
OLDNEW
« no previous file with comments | « ios/chrome/browser/BUILD.gn ('k') | ios/chrome/browser/snapshots/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698