Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issue 1725183002: MD Settings: fix "Add search engine" link regression (Closed)

Created:
4 years, 10 months ago by Dan Beam
Modified:
4 years, 9 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dpapad-patch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix "Add search engine" link regression Also tweaks primary button colors (as they should be the same as tertiary). R=dpapad@chromium.org BUG=479359 Committed: https://crrev.com/c8d107d6124a7e0f418bffbc7703728abe13040e Cr-Commit-Position: refs/heads/master@{#377315}

Patch Set 1 #

Patch Set 2 : label #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M chrome/browser/resources/settings/search_engines_page/search_engines_page.html View 1 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_shared_css.html View 1 chunk +16 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
Dan Beam
4 years, 10 months ago (2016-02-24 02:35:25 UTC) #1
dpapad
Could you also fix the left margin? See http://imgur.com/n8SlZvn (after patching this CL).
4 years, 10 months ago (2016-02-24 02:44:56 UTC) #3
Dan Beam
On 2016/02/24 02:44:56, dpapad wrote: > Could you also fix the left margin? See http://imgur.com/n8SlZvn ...
4 years, 10 months ago (2016-02-24 03:11:14 UTC) #4
dpapad
lgtm
4 years, 10 months ago (2016-02-24 03:25:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725183002/20001
4 years, 9 months ago (2016-02-24 16:16:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-02-24 17:45:56 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-02-24 17:46:49 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c8d107d6124a7e0f418bffbc7703728abe13040e
Cr-Commit-Position: refs/heads/master@{#377315}

Powered by Google App Engine
This is Rietveld 408576698