chrome/browser/resources/settings/search_engines_page/search_engines_page.html - Issue 1725183002: MD Settings: fix "Add search engine" link regression

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engines_page.html

Issue 1725183002: MD Settings: fix "Add search engine" link regression (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dpapad-patch

Patch Set: label Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/search_engines_page/search_engines_page.html

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engines_page.html b/chrome/browser/resources/settings/search_engines_page/search_engines_page.html

index 6d724bdd758e85116f81347db5643ec3abfa1d1f..44f48efff4d62de75503a3493636f8bf11768b3d 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engines_page.html

+++ b/chrome/browser/resources/settings/search_engines_page/search_engines_page.html

@@ -27,11 +27,16 @@

</template>

<div>

- <a is="action-link" i18n-content="searchEnginesAddSearchEngine"

- on-tap="onAddSearchEngineTap_" id="addSearchEngine"></a>

+ <!-- TODO(dbeam): why does on-click work with keyboard but on-tap

+ doesn't? -->

+ <div class="label">

+ <a is="action-link" i18n-content="searchEnginesAddSearchEngine"

+ on-tap="onAddSearchEngineTap_" id="addSearchEngine"></a>

+ </div>

<settings-search-engines-list engines="[[otherEngines]]">

</settings-search-engines-list>

</div>

</template>

+ <link rel="import" type="css" href="chrome://resources/css/action_link.css">

</dom-module>

« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_shared_css.html » ('j') | no next file with comments »