Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1725073003: Revert of Replace slots buffer with remembered set. (Closed)

Created:
4 years, 10 months ago by ulan
Modified:
4 years, 10 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Replace slots buffer with remembered set. (patchset #14 id:250001 of https://codereview.chromium.org/1703823002/ ) Reason for revert: Revert because of canary crashes: crbug.com/589413 Original issue's description: > Replace slots buffer with remembered set. > > Slots pointing to evacuation candidates are now recorded in the new RememberedSet<OLD_TO_OLD>. > > The remembered set is extended to support typed slots. > > During parallel evacuation all migration slots are recorded in local slots buffers. > After evacuation all local slots are added to the remembered set. > > BUG=chromium:578883 > LOG=NO > > Committed: https://crrev.com/2285a99ef6f7d52f4f0c4d88a7db4224443ee152 > Cr-Commit-Position: refs/heads/master@{#34212} TBR=jochen@chromium.org,hpayer@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:578883 Committed: https://crrev.com/9146bc5e2075797432c814b51c3e862ff959aacc Cr-Commit-Position: refs/heads/master@{#34238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+843 lines, -634 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M src/heap/incremental-marking-inl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/heap/mark-compact.h View 9 chunks +36 lines, -9 lines 0 comments Download
M src/heap/mark-compact.cc View 33 chunks +295 lines, -142 lines 0 comments Download
M src/heap/mark-compact-inl.h View 2 chunks +18 lines, -4 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 5 chunks +7 lines, -12 lines 0 comments Download
M src/heap/remembered-set.h View 4 chunks +6 lines, -142 lines 0 comments Download
M src/heap/remembered-set.cc View 3 chunks +11 lines, -18 lines 0 comments Download
M src/heap/slot-set.h View 3 chunks +2 lines, -121 lines 0 comments Download
A src/heap/slots-buffer.h View 1 chunk +175 lines, -0 lines 0 comments Download
A src/heap/slots-buffer.cc View 1 chunk +164 lines, -0 lines 0 comments Download
M src/heap/spaces.h View 8 chunks +23 lines, -49 lines 0 comments Download
M src/heap/spaces.cc View 5 chunks +4 lines, -14 lines 0 comments Download
M src/heap/spaces-inl.h View 3 chunks +19 lines, -33 lines 0 comments Download
M src/heap/store-buffer.h View 1 chunk +35 lines, -0 lines 0 comments Download
M src/heap/store-buffer-inl.h View 1 chunk +16 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 2 chunks +12 lines, -4 lines 0 comments Download
D test/unittests/heap/remembered-set-unittest.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M test/unittests/heap/slot-set-unittest.cc View 2 chunks +2 lines, -30 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ulan
Created Revert of Replace slots buffer with remembered set.
4 years, 10 months ago (2016-02-24 09:47:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725073003/1
4 years, 10 months ago (2016-02-24 09:47:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 09:48:05 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 09:48:30 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9146bc5e2075797432c814b51c3e862ff959aacc
Cr-Commit-Position: refs/heads/master@{#34238}

Powered by Google App Engine
This is Rietveld 408576698