Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Issue 172453002: A64: Fix r19474: Tidy up Push and Pop TODOs. (Closed)

Created:
6 years, 10 months ago by jbramley
Modified:
6 years, 10 months ago
Reviewers:
ulan, rmcilroy
CC:
v8-dev
Visibility:
Public.

Description

A64: Fix r19474: Tidy up Push and Pop TODOs. This fixes some snapshot=off, debug-mode regressions. - Call CheckConstPool when entering InsturctionAccurateScopes. This fixes a problem in PushMultipleTimes where 'count' is very high. Each call to PushHelper starts an InstructionAccurateScope immediately after the last one finishes, with no opportunity for the constant pool to be generated. - Temporarily disable AssertStackConsistency in PrepareForPush. This assertion seems to push the code size too far, and several cctests (intermittently) fail due to buffer size limitations. I would like to renable this assertion later. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19491

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/a64/macro-assembler-a64.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/a64/macro-assembler-a64.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jbramley
I had to add a TODO to re-enable AssertStackConsistency. I'll create an issue for it ...
6 years, 10 months ago (2014-02-19 14:33:35 UTC) #1
ulan
lgtm, thanks!
6 years, 10 months ago (2014-02-19 14:35:29 UTC) #2
jbramley
6 years, 10 months ago (2014-02-19 14:37:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19491 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698