src/a64/macro-assembler-a64.cc - Issue 172453002: A64: Fix r19474: Tidy up Push and Pop TODOs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/a64/macro-assembler-a64.cc

Issue 172453002: A64: Fix r19474: Tidy up Push and Pop TODOs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/a64/macro-assembler-a64.cc

diff --git a/src/a64/macro-assembler-a64.cc b/src/a64/macro-assembler-a64.cc

index fe68b08774d3794bee57646429a61b9fc0779671..cd6b60a8e51489ad05780e9a4d41d6086f8d42d3 100644

--- a/src/a64/macro-assembler-a64.cc

+++ b/src/a64/macro-assembler-a64.cc

@@ -1079,7 +1079,8 @@ void MacroAssembler::PopHelper(int count, int size,

void MacroAssembler::PrepareForPush(Operand total_size) {

- AssertStackConsistency();

+ // TODO(jbramley): This assertion generates too much code in some debug tests.

+ // AssertStackConsistency();

if (csp.Is(StackPointer())) {

// If the current stack pointer is csp, then it must be aligned to 16 bytes

// on entry and the total size of the specified registers must also be a

« no previous file with comments | « src/a64/macro-assembler-a64.h ('k') | no next file » | no next file with comments »