Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1724483002: Remove CFX_ThreadLock (its a no-op) (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove CFX_ThreadLock (its a no-op) We wouldn't want to imply that any of this is thread-safe ... R=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/2373da22a2e754ae9b0e7d913da0ce2e925f76a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -80 lines) Patch
M xfa/src/fdp/src/css/fde_csscache.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fdp/src/css/fde_csssyntax.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/src/fdp/src/fde/fde_render.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/src/fdp/src/fde/fde_render.cpp View 6 chunks +3 lines, -11 lines 0 comments Download
M xfa/src/fdp/src/xml/fde_xml_imp.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/src/fgas/include/fx_stm.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/src/fgas/include/fx_utl.h View 2 chunks +0 lines, -8 lines 0 comments Download
M xfa/src/fgas/src/crt/fx_stream.h View 5 chunks +3 lines, -8 lines 0 comments Download
M xfa/src/fgas/src/crt/fx_stream.cpp View 13 chunks +1 line, -19 lines 0 comments Download
M xfa/src/fgas/src/crt/fx_utils.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M xfa/src/fgas/src/font/fx_gdifont.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fgas/src/font/fx_gefont.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fgas/src/font/fx_gefont.cpp View 11 chunks +2 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Tom Sepez
Dan, quick review.
4 years, 10 months ago (2016-02-22 19:18:19 UTC) #3
dsinclair
lgtm
4 years, 10 months ago (2016-02-22 19:20:13 UTC) #4
Tom Sepez
4 years, 10 months ago (2016-02-22 19:23:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2373da22a2e754ae9b0e7d913da0ce2e925f76a0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698