xfa/src/fdp/src/css/fde_csssyntax.cpp - Issue 1724483002: Remove CFX_ThreadLock (its a no-op)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fdp/src/css/fde_csssyntax.cpp

Issue 1724483002: Remove CFX_ThreadLock (its a no-op) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fdp/src/css/fde_csssyntax.cpp

diff --git a/xfa/src/fdp/src/css/fde_csssyntax.cpp b/xfa/src/fdp/src/css/fde_csssyntax.cpp

index b546d1046ff74429c498f40e13c431dd284fef9c..15b8dbb23a9bb1eb1a6bfcd6dbeb9168e574b6d7 100644

--- a/xfa/src/fdp/src/css/fde_csssyntax.cpp

+++ b/xfa/src/fdp/src/css/fde_csssyntax.cpp

@@ -444,12 +444,10 @@ int32_t CFDE_CSSTextBuf::LoadFromStream(IFX_Stream* pTxtStream,

if (!ExpandBuf(iMaxChars)) {

return 0;

}

- pTxtStream->Lock();

if (pTxtStream->GetPosition() != iStreamOffset) {

pTxtStream->Seek(FX_STREAMSEEK_Begin, iStreamOffset);

}

m_iDatLen = pTxtStream->ReadString(m_pBuffer, iMaxChars, bEOS);

- pTxtStream->Unlock();

return m_iDatLen;

}

FX_BOOL CFDE_CSSTextBuf::ExpandBuf(int32_t iDesiredSize) {

« no previous file with comments | « xfa/src/fdp/src/css/fde_csscache.h ('k') | xfa/src/fdp/src/fde/fde_render.h » ('j') | no next file with comments »