Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1724473004: X87: Emit memory operands for cmp and test on ia32 and x64 when it makes sense. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Emit memory operands for cmp and test on ia32 and x64 when it makes sense. port 0e43ff5632d38cfb8b0ea0bc6955d6f252cb9ad8 (r34187) original commit message: The InstructionSelector now associates an effect level to every node in a block. The effect level of a node is the number of non-eliminatable nodes encountered from the beginning of the block to the node itself. With this change, on ia32 and x64, a load from memory into a register can be replaced by a memory operand if all of the following conditions hold: 1. The only use of the load is in a 32 or 64 bit word comparison. 2. The user node and the load node belong to the same block. 3. The values of the operands have the same size (i.e., no need to zero-extend or sign-extend the result of the load). BUG= Committed: https://crrev.com/e1b9058f9e0bb1238ffcd311f6b48bb12b6113e0 Cr-Commit-Position: refs/heads/master@{#34204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -42 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +26 lines, -6 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 2 chunks +66 lines, -11 lines 0 comments Download
M src/x87/assembler-x87.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/assembler-x87.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x87/disasm-x87.cc View 1 chunk +23 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-23 02:38:49 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-23 03:07:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1724473004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1724473004/1
4 years, 10 months ago (2016-02-23 05:58:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 06:16:23 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 06:17:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1b9058f9e0bb1238ffcd311f6b48bb12b6113e0
Cr-Commit-Position: refs/heads/master@{#34204}

Powered by Google App Engine
This is Rietveld 408576698