Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/x87/assembler-x87.cc

Issue 1724473004: X87: Emit memory operands for cmp and test on ia32 and x64 when it makes sense. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x87/assembler-x87.h ('k') | src/x87/disasm-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 656 matching lines...) Expand 10 before | Expand all | Expand 10 after
667 emit_arith(7, Operand(reg), Immediate(handle)); 667 emit_arith(7, Operand(reg), Immediate(handle));
668 } 668 }
669 669
670 670
671 void Assembler::cmp(Register reg, const Operand& op) { 671 void Assembler::cmp(Register reg, const Operand& op) {
672 EnsureSpace ensure_space(this); 672 EnsureSpace ensure_space(this);
673 EMIT(0x3B); 673 EMIT(0x3B);
674 emit_operand(reg, op); 674 emit_operand(reg, op);
675 } 675 }
676 676
677 void Assembler::cmp(const Operand& op, Register reg) {
678 EnsureSpace ensure_space(this);
679 EMIT(0x39);
680 emit_operand(reg, op);
681 }
677 682
678 void Assembler::cmp(const Operand& op, const Immediate& imm) { 683 void Assembler::cmp(const Operand& op, const Immediate& imm) {
679 EnsureSpace ensure_space(this); 684 EnsureSpace ensure_space(this);
680 emit_arith(7, op, imm); 685 emit_arith(7, op, imm);
681 } 686 }
682 687
683 688
684 void Assembler::cmp(const Operand& op, Handle<Object> handle) { 689 void Assembler::cmp(const Operand& op, Handle<Object> handle) {
685 EnsureSpace ensure_space(this); 690 EnsureSpace ensure_space(this);
686 emit_arith(7, op, Immediate(handle)); 691 emit_arith(7, op, Immediate(handle));
(...skipping 1421 matching lines...) Expand 10 before | Expand all | Expand 10 after
2108 fflush(coverage_log); 2113 fflush(coverage_log);
2109 } 2114 }
2110 } 2115 }
2111 2116
2112 #endif 2117 #endif
2113 2118
2114 } // namespace internal 2119 } // namespace internal
2115 } // namespace v8 2120 } // namespace v8
2116 2121
2117 #endif // V8_TARGET_ARCH_X87 2122 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/x87/assembler-x87.h ('k') | src/x87/disasm-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698