chrome/chrome_browser.gypi - Issue 1724183005: Change ChooserBubbleDelegate class name to ChooserBubbleController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 1724183005: Change ChooserBubbleDelegate class name to ChooserBubbleController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed typo Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 5dfafa93c3a92e6869cc17f9f17da21b4725d2e4..2273315db111ad0e47a0d7065534f10b037dfa6c 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1378,8 +1378,8 @@

'browser/tracing/chrome_tracing_delegate.h',

'browser/upgrade_detector.cc',

'browser/upgrade_detector.h',

- 'browser/usb/usb_chooser_bubble_delegate.cc',

- 'browser/usb/usb_chooser_bubble_delegate.h',

+ 'browser/usb/usb_chooser_bubble_controller.cc',

+ 'browser/usb/usb_chooser_bubble_controller.h',

'browser/usb/web_usb_permission_bubble.cc',

'browser/usb/web_usb_permission_bubble.h',

Evan Stade 2016/02/24 22:17:54 hmmm, these things seem like they belong in ui/...

juncai 2016/02/24 22:44:33 ah, I see, maybe it is because the filenames web_u

« no previous file with comments | « chrome/browser/usb/web_usb_permission_bubble.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »