Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 1724183005: Change ChooserBubbleDelegate class name to ChooserBubbleController (Closed)

Created:
4 years, 10 months ago by juncai
Modified:
4 years, 10 months ago
Reviewers:
sky, Evan Stade
CC:
chromium-reviews, tfarina, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change ChooserBubbleDelegate class name to ChooserBubbleController This patch changed ChooserBubbleDelegate class name to ChooserBubbleController since it better reflects the class's responsibilities and clarifies the roles of the class. BUG=492204, 588933 Committed: https://crrev.com/a2ad62074ea877b0440571c074fe49352e49aa4f Cr-Commit-Position: refs/heads/master@{#377989}

Patch Set 1 : changed ChooserBubbleDelegate class name to ChooserBubbleController #

Patch Set 2 : fixed typo #

Total comments: 2

Patch Set 3 : merged changes from master, resolved conflicts and updated related files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -743 lines) Patch
A + chrome/browser/ui/bluetooth/bluetooth_chooser_bubble_controller.h View 1 2 2 chunks +13 lines, -13 lines 0 comments Download
A + chrome/browser/ui/bluetooth/bluetooth_chooser_bubble_controller.cc View 4 chunks +17 lines, -17 lines 0 comments Download
D chrome/browser/ui/bluetooth/bluetooth_chooser_bubble_delegate.h View 1 2 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/ui/bluetooth/bluetooth_chooser_bubble_delegate.cc View 1 chunk +0 lines, -85 lines 0 comments Download
M chrome/browser/ui/bluetooth/bluetooth_chooser_desktop.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/bluetooth/bluetooth_chooser_desktop.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 2 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h View 1 2 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm View 1 2 12 chunks +34 lines, -31 lines 0 comments Download
M chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc View 15 chunks +28 lines, -30 lines 0 comments Download
A + chrome/browser/ui/website_settings/chooser_bubble_controller.h View 4 chunks +8 lines, -12 lines 0 comments Download
A + chrome/browser/ui/website_settings/chooser_bubble_controller.cc View 1 chunk +8 lines, -6 lines 0 comments Download
D chrome/browser/ui/website_settings/chooser_bubble_delegate.h View 1 chunk +0 lines, -103 lines 0 comments Download
D chrome/browser/ui/website_settings/chooser_bubble_delegate.cc View 1 chunk +0 lines, -29 lines 0 comments Download
A + chrome/browser/usb/usb_chooser_bubble_controller.h View 1 2 5 chunks +14 lines, -14 lines 0 comments Download
A + chrome/browser/usb/usb_chooser_bubble_controller.cc View 7 chunks +24 lines, -22 lines 0 comments Download
D chrome/browser/usb/usb_chooser_bubble_delegate.h View 1 2 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/usb/usb_chooser_bubble_delegate.cc View 1 chunk +0 lines, -201 lines 0 comments Download
M chrome/browser/usb/web_usb_permission_bubble.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
juncai
Please review this patch.
4 years, 10 months ago (2016-02-24 21:07:10 UTC) #3
Evan Stade
thanks for getting to this so promptly! lgtm +sky for OWNERS review https://codereview.chromium.org/1724183005/diff/20001/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi ...
4 years, 10 months ago (2016-02-24 22:17:54 UTC) #5
juncai
https://codereview.chromium.org/1724183005/diff/20001/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (left): https://codereview.chromium.org/1724183005/diff/20001/chrome/chrome_browser.gypi#oldcode1384 chrome/chrome_browser.gypi:1384: 'browser/usb/web_usb_permission_bubble.h', On 2016/02/24 22:17:54, Evan Stade wrote: > hmmm, ...
4 years, 10 months ago (2016-02-24 22:44:33 UTC) #6
sky
LGTM
4 years, 10 months ago (2016-02-25 01:02:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1724183005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1724183005/40001
4 years, 10 months ago (2016-02-26 21:48:47 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-26 21:57:04 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 21:58:44 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a2ad62074ea877b0440571c074fe49352e49aa4f
Cr-Commit-Position: refs/heads/master@{#377989}

Powered by Google App Engine
This is Rietveld 408576698