Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 1724103002: Reverting changes that made window.scroll properties relative to the layout viewport. (Closed)

Created:
3 years, 5 months ago by ymalik
Modified:
3 years, 5 months ago
Reviewers:
kenrb, Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

Reverting changes that made window.scroll properties relative to the layout viewport. Reason for revert: Broke a bunch of sites that relied on visual viewport coordinates (see www.crbug.com/571297). Reverting temporary until a new api that provides visual viewport coordinates is made available to developers. Revert "Make window.scroll properties relative to the layout viewport by default." This reverts commit f75faf53de4a5c59269143b6edbfc6dc40c7fb33. Revert "Remove plumbing for the inert-visual-viewport flag." This reverts commit 58d42ae1d6690a9f625e23f160b346e9cebeab01. TBR=avi@chromium.org,kenrb@chromium.org BUG=571297 Review URL: https://codereview.chromium.org/1712743002 Cr-Commit-Position: refs/heads/master@{#376742} (cherry picked from commit 835268c26a1f84e944b70d69703a54c4cb50bc5b) Committed: https://chromium.googlesource.com/chromium/src/+/6fa68739e94ac02e8b2363b36eca05b9591ded0f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -192 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/web_preferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/web_preferences.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/window-scaled-viewport-properties.html View 2 chunks +90 lines, -68 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/window-scaled-viewport-properties-expected.txt View 2 chunks +25 lines, -43 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/window-inner-size-scaling.html View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/window-inner-size-scaling-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/fixed-right-bottom-in-page-scale.html View 1 chunk +1 line, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/scroll-behavior/visual-viewport-scroll-no-onscroll-event.html View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/scroll-behavior/visual-viewport-scroll-no-onscroll-event-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Settings.in View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/DummyPageHolder.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 2 chunks +136 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebSettings.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ymalik
3 years, 5 months ago (2016-02-23 20:08:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6fa68739e94ac02e8b2363b36eca05b9591ded0f.

Powered by Google App Engine
This is Rietveld 408576698