third_party/WebKit/LayoutTests/fast/scroll-behavior/visual-viewport-scroll-no-onscroll-event.html - Issue 1724103002: Reverting changes that made window.scroll properties relative to the layout viewport.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/scroll-behavior/visual-viewport-scroll-no-onscroll-event.html

Issue 1724103002: Reverting changes that made window.scroll properties relative to the layout viewport. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2623

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/repaint/fixed-right-bottom-in-page-scale.html ('k') | third_party/WebKit/LayoutTests/fast/scroll-behavior/visual-viewport-scroll-no-onscroll-event-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 <!DOCTYPE html>

2 <script src="../../resources/js-test.js"></script>

3 <style>

4 #target {

5 width: 2000px;

6 height: 1500px;

7 }

8 </style>

9 <script>

10 var numScrollsReceived = 0;

11 var numRAFCalls = 0;

12 if (window.testRunner && window.internals) {

13 window.jsTestIsAsync = true;

14 testRunner.dumpAsText();

15 testRunner.waitUntilDone();

16 setPrintTestResultsLazily();

17 }

18

19 description("This test ensures that scrolling the visual viewport doesn't\

20 trigger an onscroll event.");

21

22 function runTest() {

23 if (!window.testRunner \|\| !window.internals) {

24 testFailed("This test requires test runner and internals")

25 finishJSTest();

26 return;

27 }

28

29 internals.settings.setScrollAnimatorEnabled(false);

30

31 window.internals.setPageScaleFactor(2.0);

32 var target = document.getElementById('target');

33

34 document.onscroll = function() {

35 ++numScrollsReceived;

36 debug('OnScroll called for scroll #' + numScrollsReceived);

37 }

38

39 var failureSentinel = function() {

40 if (numRAFCalls == 0) {

41 // The first scroll should trigger onscroll because it scrolls

42 // the layout viewport.

43 eventSender.mouseMoveTo(target.offsetLeft + 5, target.offsetTop + 5);

44 eventSender.continuousMouseScrollBy(0, -400);

45 } else if (numRAFCalls == 1) {

46 shouldBe('numScrollsReceived', '1');

47 // The second scroll should not trigger onscroll because it only

48 // scrolls the visual viewport.

49 eventSender.mouseMoveTo(target.offsetLeft + 5, target.offsetTop + 5);

50 eventSender.continuousMouseScrollBy(0, 40);

51 } else {

52 shouldBe('numScrollsReceived', '1');

53 finishJSTest();

54 return;

55 }

56 ++numRAFCalls;

57 window.requestAnimationFrame(failureSentinel);

58 }

59

60 window.requestAnimationFrame(failureSentinel);

61 }

62

63 onload = runTest;

64 </script>

65 <div id="target"></div>

OLD	NEW