Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: content/public/browser/render_view_host.h

Issue 1723763002: Add WebDragData to blink::WebView::dragtargetDrop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Send "meta data" of dropData in DragEnter Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/drag_traits.h ('k') | content/public/common/drop_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/render_view_host.h
diff --git a/content/public/browser/render_view_host.h b/content/public/browser/render_view_host.h
index 1a4d1646d708a80fc6c84e0c3b7e821212ca1f98..134326908dd8cd9766c5571ac0fbc136f18bafac 100644
--- a/content/public/browser/render_view_host.h
+++ b/content/public/browser/render_view_host.h
@@ -130,6 +130,9 @@ class CONTENT_EXPORT RenderViewHost : public IPC::Sender {
virtual void DragSourceSystemDragEnded() = 0;
// D&d drop target messages that get sent to WebKit.
+ // On Android, drop data is not available at DragTargetDragEnter. So only a
+ // dummy drop_data with the data format is passed. On Aura, the drop data is
+ // available and passed in here.
dcheng 2016/03/30 08:40:02 I think there's no need to mention Android vs non-
hush (inactive) 2016/04/06 22:47:51 I will remove this comment.
virtual void DragTargetDragEnter(
const DropData& drop_data,
const gfx::Point& client_pt,
@@ -142,7 +145,14 @@ class CONTENT_EXPORT RenderViewHost : public IPC::Sender {
blink::WebDragOperationsMask operations_allowed,
int key_modifiers) = 0;
virtual void DragTargetDragLeave() = 0;
- virtual void DragTargetDrop(const gfx::Point& client_pt,
+ // Drop data is only valid on Android during DragTargetDrop because this is
+ // the only time when drop data is accessible on Andorid.
+ // http://developer.android.com/reference/android/view/DragEvent.html
+ // On Aura, drop data at this time will be the same as it was in DragEnter,
+ // and an invalid drop data will be passed down to indicate reusing the drop
+ // data from DragEnter.
dcheng 2016/03/30 08:40:02 Is this comment still accurate?
hush (inactive) 2016/04/06 22:47:51 Nope. Removed.
+ virtual void DragTargetDrop(const DropData& drop_data,
+ const gfx::Point& client_pt,
const gfx::Point& screen_pt,
int key_modifiers) = 0;
« no previous file with comments | « content/common/drag_traits.h ('k') | content/public/common/drop_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698