Chromium Code Reviews| Index: content/public/browser/render_view_host.h |
| diff --git a/content/public/browser/render_view_host.h b/content/public/browser/render_view_host.h |
| index 1a4d1646d708a80fc6c84e0c3b7e821212ca1f98..134326908dd8cd9766c5571ac0fbc136f18bafac 100644 |
| --- a/content/public/browser/render_view_host.h |
| +++ b/content/public/browser/render_view_host.h |
| @@ -130,6 +130,9 @@ class CONTENT_EXPORT RenderViewHost : public IPC::Sender { |
| virtual void DragSourceSystemDragEnded() = 0; |
| // D&d drop target messages that get sent to WebKit. |
| + // On Android, drop data is not available at DragTargetDragEnter. So only a |
| + // dummy drop_data with the data format is passed. On Aura, the drop data is |
| + // available and passed in here. |
|
dcheng
2016/03/30 08:40:02
I think there's no need to mention Android vs non-
hush (inactive)
2016/04/06 22:47:51
I will remove this comment.
|
| virtual void DragTargetDragEnter( |
| const DropData& drop_data, |
| const gfx::Point& client_pt, |
| @@ -142,7 +145,14 @@ class CONTENT_EXPORT RenderViewHost : public IPC::Sender { |
| blink::WebDragOperationsMask operations_allowed, |
| int key_modifiers) = 0; |
| virtual void DragTargetDragLeave() = 0; |
| - virtual void DragTargetDrop(const gfx::Point& client_pt, |
| + // Drop data is only valid on Android during DragTargetDrop because this is |
| + // the only time when drop data is accessible on Andorid. |
| + // http://developer.android.com/reference/android/view/DragEvent.html |
| + // On Aura, drop data at this time will be the same as it was in DragEnter, |
| + // and an invalid drop data will be passed down to indicate reusing the drop |
| + // data from DragEnter. |
|
dcheng
2016/03/30 08:40:02
Is this comment still accurate?
hush (inactive)
2016/04/06 22:47:51
Nope. Removed.
|
| + virtual void DragTargetDrop(const DropData& drop_data, |
| + const gfx::Point& client_pt, |
| const gfx::Point& screen_pt, |
| int key_modifiers) = 0; |