Add WebDragData to blink::WebView::dragtargetDrop

content/public/browser/render_view_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_RENDER_VIEW_HOST_H_
 #define CONTENT_PUBLIC_BROWSER_RENDER_VIEW_HOST_H_
 
 #include "base/callback_forward.h"
 #include "build/build_config.h"
 #include "content/common/content_export.h"
@@ skipping 112 matching lines @@
   // either in a drop or by being cancelled.
   virtual void DragSourceEndedAt(
       int client_x, int client_y, int screen_x, int screen_y,
       blink::WebDragOperation operation) = 0;
 
   // Notifies the renderer that we're done with the drag and drop operation.
   // This allows the renderer to reset some state.
   virtual void DragSourceSystemDragEnded() = 0;
 
   // D&d drop target messages that get sent to WebKit.
+  // On Android, drop data is not available at DragTargetDragEnter. So only a
+  // dummy drop_data with the data format is passed. On Aura, the drop data is
+  // available and passed in here.

[dcheng, 2016/03/30 08:40:02]

I think there's no need to mention Android vs non-Android.

[hush (inactive), 2016/04/06 22:47:51]

I will remove this comment.

   virtual void DragTargetDragEnter(
       const DropData& drop_data,
       const gfx::Point& client_pt,
       const gfx::Point& screen_pt,
       blink::WebDragOperationsMask operations_allowed,
       int key_modifiers) = 0;
   virtual void DragTargetDragOver(
       const gfx::Point& client_pt,
       const gfx::Point& screen_pt,
       blink::WebDragOperationsMask operations_allowed,
       int key_modifiers) = 0;
   virtual void DragTargetDragLeave() = 0;
-  virtual void DragTargetDrop(const gfx::Point& client_pt,
+  // Drop data is only valid on Android during DragTargetDrop because this is
+  // the only time when drop data is accessible on Andorid.
+  // http://developer.android.com/reference/android/view/DragEvent.html
+  // On Aura, drop data at this time will be the same as it was in DragEnter,
+  // and an invalid drop data will be passed down to indicate reusing the drop
+  // data from DragEnter.

[dcheng, 2016/03/30 08:40:02]

Is this comment still accurate?

[hush (inactive), 2016/04/06 22:47:51]

Nope. Removed.

+  virtual void DragTargetDrop(const DropData& drop_data,
+                              const gfx::Point& client_pt,
                               const gfx::Point& screen_pt,
                               int key_modifiers) = 0;
 
   // Instructs the RenderView to automatically resize and send back updates
   // for the new size.
   virtual void EnableAutoResize(const gfx::Size& min_size,
                                 const gfx::Size& max_size) = 0;
 
   // Turns off auto-resize and gives a new size that the view should be.
   virtual void DisableAutoResize(const gfx::Size& new_size) = 0;
@@ skipping 62 matching lines @@
 
  private:
   // This interface should only be implemented inside content.
   friend class RenderViewHostImpl;
   RenderViewHost() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_RENDER_VIEW_HOST_H_