Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: runtime/vm/profiler_test.cc

Issue 1723733002: Simplify various name flavors in VM. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/profiler_test.cc
diff --git a/runtime/vm/profiler_test.cc b/runtime/vm/profiler_test.cc
index 55149b2bd04227ebde0bc963e0df68ab2b54017f..3d29810d7c28d1a4f655d762482ae2224b33caea 100644
--- a/runtime/vm/profiler_test.cc
+++ b/runtime/vm/profiler_test.cc
@@ -660,9 +660,9 @@ TEST_CASE(Profiler_IntrinsicAllocation) {
walker.Reset(Profile::kExclusiveCode);
EXPECT(walker.Down());
- EXPECT_STREQ("_Double._add", walker.CurrentName());
+ EXPECT_STREQ("double._add", walker.CurrentName());
EXPECT(walker.Down());
- EXPECT_STREQ("_Double.+", walker.CurrentName());
+ EXPECT_STREQ("double.+", walker.CurrentName());
EXPECT(walker.Down());
EXPECT_STREQ("foo", walker.CurrentName());
EXPECT(!walker.Down());
@@ -728,7 +728,7 @@ TEST_CASE(Profiler_ArrayAllocation) {
walker.Reset(Profile::kExclusiveCode);
EXPECT(walker.Down());
- EXPECT_STREQ("_List._List", walker.CurrentName());
+ EXPECT_STREQ("List._List", walker.CurrentName());
EXPECT(walker.Down());
EXPECT_STREQ("List.List", walker.CurrentName());
EXPECT(walker.Down());
@@ -776,9 +776,9 @@ TEST_CASE(Profiler_ArrayAllocation) {
walker.Reset(Profile::kExclusiveCode);
EXPECT(walker.Down());
- EXPECT_STREQ("_List._List", walker.CurrentName());
+ EXPECT_STREQ("List._List", walker.CurrentName());
EXPECT(walker.Down());
- EXPECT_STREQ("_GrowableList._GrowableList", walker.CurrentName());
+ EXPECT_STREQ("List._GrowableList", walker.CurrentName());
EXPECT(walker.Down());
EXPECT_STREQ("List.List", walker.CurrentName());
EXPECT(walker.Down());
@@ -970,9 +970,9 @@ TEST_CASE(Profiler_TypedArrayAllocation) {
walker.Reset(Profile::kExclusiveCode);
EXPECT(walker.Down());
- EXPECT_STREQ("_Float32Array._new", walker.CurrentName());
+ EXPECT_STREQ("Float32List._new", walker.CurrentName());
EXPECT(walker.Down());
- EXPECT_STREQ("_Float32Array._Float32Array", walker.CurrentName());
+ EXPECT_STREQ("Float32List._Float32Array", walker.CurrentName());
EXPECT(walker.Down());
EXPECT_STREQ("Float32List.Float32List", walker.CurrentName());
EXPECT(walker.Down());
@@ -1134,9 +1134,9 @@ TEST_CASE(Profiler_StringInterpolation) {
walker.Reset(Profile::kExclusiveCode);
EXPECT(walker.Down());
- EXPECT_STREQ("_OneByteString._allocate", walker.CurrentName());
+ EXPECT_STREQ("String._allocate", walker.CurrentName());
EXPECT(walker.Down());
- EXPECT_STREQ("_OneByteString._concatAll", walker.CurrentName());
+ EXPECT_STREQ("String._concatAll", walker.CurrentName());
EXPECT(walker.Down());
EXPECT_STREQ("_StringBase._interpolate", walker.CurrentName());
EXPECT(walker.Down());
« runtime/observatory/tests/service/get_object_rpc_test.dart ('K') | « runtime/vm/profiler_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698