Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/observatory/tests/service/get_object_rpc_test.dart

Issue 1723733002: Simplify various name flavors in VM. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/observatory/tests/service/implicit_getter_setter_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/get_object_rpc_test.dart
diff --git a/runtime/observatory/tests/service/get_object_rpc_test.dart b/runtime/observatory/tests/service/get_object_rpc_test.dart
index a98c53598eae7f07f3b5dfa91ada15b55f4736c4..49d63503ad604b8572078fee3c0d88fe4cd47b66 100644
--- a/runtime/observatory/tests/service/get_object_rpc_test.dart
+++ b/runtime/observatory/tests/service/get_object_rpc_test.dart
@@ -81,7 +81,7 @@ var tests = [
expect(result['id'], equals('objects/int-123'));
expect(result['valueAsString'], equals('123'));
expect(result['class']['type'], equals('@Class'));
- expect(result['class']['name'], equals('_Smi'));
+ expect(result['class']['name'], equals('int'));
Cutch 2016/02/23 17:42:53 I think we still want to use the ScrubbedName (the
expect(result['size'], isZero);
expect(result['fields'], isEmpty);
},
@@ -100,7 +100,7 @@ var tests = [
expect(result['id'], startsWith('objects/'));
expect(result['valueAsString'], equals('Chattanooga'));
expect(result['class']['type'], equals('@Class'));
- expect(result['class']['name'], equals('_OneByteString'));
+ expect(result['class']['name'], equals('String'));
expect(result['size'], isPositive);
expect(result['fields'], isEmpty);
expect(result['length'], equals(11));
@@ -123,7 +123,7 @@ var tests = [
expect(result['id'], startsWith('objects/'));
expect(result['valueAsString'], equals('Chat'));
expect(result['class']['type'], equals('@Class'));
- expect(result['class']['name'], equals('_OneByteString'));
+ expect(result['class']['name'], equals('String'));
expect(result['size'], isPositive);
expect(result['fields'], isEmpty);
expect(result['length'], equals(11));
@@ -147,7 +147,7 @@ var tests = [
expect(result['id'], startsWith('objects/'));
expect(result['valueAsString'], equals('tanoog'));
expect(result['class']['type'], equals('@Class'));
- expect(result['class']['name'], equals('_OneByteString'));
+ expect(result['class']['name'], equals('String'));
expect(result['size'], isPositive);
expect(result['fields'], isEmpty);
expect(result['length'], equals(11));
@@ -171,7 +171,7 @@ var tests = [
expect(result['id'], startsWith('objects/'));
expect(result['valueAsString'], equals(''));
expect(result['class']['type'], equals('@Class'));
- expect(result['class']['name'], equals('_OneByteString'));
+ expect(result['class']['name'], equals('String'));
expect(result['size'], isPositive);
expect(result['fields'], isEmpty);
expect(result['length'], equals(11));
@@ -193,7 +193,7 @@ var tests = [
expect(result['id'], startsWith('objects/'));
expect(result['valueAsString'], isNull);
expect(result['class']['type'], equals('@Class'));
- expect(result['class']['name'], equals('_GrowableList'));
+ expect(result['class']['name'], equals('List'));
expect(result['size'], isPositive);
expect(result['fields'], isEmpty);
expect(result['length'], equals(3));
@@ -226,7 +226,7 @@ var tests = [
expect(result['id'], startsWith('objects/'));
expect(result['valueAsString'], isNull);
expect(result['class']['type'], equals('@Class'));
- expect(result['class']['name'], equals('_GrowableList'));
+ expect(result['class']['name'], equals('List'));
expect(result['size'], isPositive);
expect(result['fields'], isEmpty);
expect(result['length'], equals(3));
@@ -257,7 +257,7 @@ var tests = [
expect(result['id'], startsWith('objects/'));
expect(result['valueAsString'], isNull);
expect(result['class']['type'], equals('@Class'));
- expect(result['class']['name'], equals('_GrowableList'));
+ expect(result['class']['name'], equals('List'));
expect(result['size'], isPositive);
expect(result['fields'], isEmpty);
expect(result['length'], equals(3));
@@ -285,7 +285,7 @@ var tests = [
expect(result['id'], startsWith('objects/'));
expect(result['valueAsString'], isNull);
expect(result['class']['type'], equals('@Class'));
- expect(result['class']['name'], equals('_GrowableList'));
+ expect(result['class']['name'], equals('List'));
expect(result['size'], isPositive);
expect(result['fields'], isEmpty);
expect(result['length'], equals(3));
@@ -441,7 +441,7 @@ var tests = [
expect(result['id'], startsWith('objects/'));
expect(result['valueAsString'], isNull);
expect(result['class']['type'], equals('@Class'));
- expect(result['class']['name'], equals('_Uint8Array'));
+ expect(result['class']['name'], equals('Uint8List'));
expect(result['size'], isPositive);
expect(result['fields'], isEmpty);
expect(result['length'], equals(3));
@@ -467,7 +467,7 @@ var tests = [
expect(result['id'], startsWith('objects/'));
expect(result['valueAsString'], isNull);
expect(result['class']['type'], equals('@Class'));
- expect(result['class']['name'], equals('_Uint8Array'));
+ expect(result['class']['name'], equals('Uint8List'));
expect(result['size'], isPositive);
expect(result['fields'], isEmpty);
expect(result['length'], equals(3));
@@ -494,7 +494,7 @@ var tests = [
expect(result['id'], startsWith('objects/'));
expect(result['valueAsString'], isNull);
expect(result['class']['type'], equals('@Class'));
- expect(result['class']['name'], equals('_Uint8Array'));
+ expect(result['class']['name'], equals('Uint8List'));
expect(result['size'], isPositive);
expect(result['fields'], isEmpty);
expect(result['length'], equals(3));
@@ -521,7 +521,7 @@ var tests = [
expect(result['id'], startsWith('objects/'));
expect(result['valueAsString'], isNull);
expect(result['class']['type'], equals('@Class'));
- expect(result['class']['name'], equals('_Uint8Array'));
+ expect(result['class']['name'], equals('Uint8List'));
expect(result['size'], isPositive);
expect(result['fields'], isEmpty);
expect(result['length'], equals(3));
@@ -544,7 +544,7 @@ var tests = [
expect(result['id'], startsWith('objects/'));
expect(result['valueAsString'], isNull);
expect(result['class']['type'], equals('@Class'));
- expect(result['class']['name'], equals('_Uint64Array'));
+ expect(result['class']['name'], equals('Uint64List'));
expect(result['size'], isPositive);
expect(result['fields'], isEmpty);
expect(result['length'], equals(3));
@@ -570,7 +570,7 @@ var tests = [
expect(result['id'], startsWith('objects/'));
expect(result['valueAsString'], isNull);
expect(result['class']['type'], equals('@Class'));
- expect(result['class']['name'], equals('_Uint64Array'));
+ expect(result['class']['name'], equals('Uint64List'));
expect(result['size'], isPositive);
expect(result['fields'], isEmpty);
expect(result['length'], equals(3));
@@ -597,7 +597,7 @@ var tests = [
expect(result['id'], startsWith('objects/'));
expect(result['valueAsString'], isNull);
expect(result['class']['type'], equals('@Class'));
- expect(result['class']['name'], equals('_Uint64Array'));
+ expect(result['class']['name'], equals('Uint64List'));
expect(result['size'], isPositive);
expect(result['fields'], isEmpty);
expect(result['length'], equals(3));
@@ -624,7 +624,7 @@ var tests = [
expect(result['id'], startsWith('objects/'));
expect(result['valueAsString'], isNull);
expect(result['class']['type'], equals('@Class'));
- expect(result['class']['name'], equals('_Uint64Array'));
+ expect(result['class']['name'], equals('Uint64List'));
expect(result['size'], isPositive);
expect(result['fields'], isEmpty);
expect(result['length'], equals(3));
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/observatory/tests/service/implicit_getter_setter_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698