ios/chrome/browser/passwords/credential_manager.mm - Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/passwords/credential_manager.mm

Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: iOS2 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/save_password_infobar_delegate.cc ('K') | « components/password_manager/core/common/credential_manager_types_unittest.cc ('k') | ios/web/public/web_state/credential.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/passwords/credential_manager.mm

diff --git a/ios/chrome/browser/passwords/credential_manager.mm b/ios/chrome/browser/passwords/credential_manager.mm

index 9549c7ef8897c53765c77fc326f409578a6accec..7376962e22b7bc64d8a0c05d64ce73df58356c92 100644

--- a/ios/chrome/browser/passwords/credential_manager.mm

+++ b/ios/chrome/browser/passwords/credential_manager.mm

@@ -20,6 +20,7 @@

#include "ios/web/public/web_state/credential.h"

#include "ios/web/public/web_state/url_verification_constants.h"

#include "ios/web/public/web_state/web_state.h"

+#include "url/origin.h"

namespace {

@@ -42,7 +43,7 @@ web::Credential WebCredentialFromCredentialInfo(

credential.name = credential_info.name;

credential.avatar_url = credential_info.icon;

credential.password = credential_info.password;

- credential.federation_url = credential_info.federation;

+ credential.federation_origin = credential_info.federation;

return credential;

}

@@ -68,7 +69,7 @@ password_manager::CredentialInfo CredentialInfoFromWebCredential(

credential_info.name = credential.name;

credential_info.icon = credential.avatar_url;

credential_info.password = credential.password;

- credential_info.federation = credential.federation_url;

+ credential_info.federation = credential.federation_origin;

return credential_info;

}