components/password_manager/core/common/credential_manager_types.h - Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/common/credential_manager_types.h

Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: iOS2 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/save_password_infobar_delegate.cc ('K') | « components/password_manager/core/browser/password_syncable_service_unittest.cc ('k') | components/password_manager/core/common/credential_manager_types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/common/credential_manager_types.h

diff --git a/components/password_manager/core/common/credential_manager_types.h b/components/password_manager/core/common/credential_manager_types.h

index 7f7b17059b331c4071abb25cb2810c07f610a737..cd712f7550c49aa877de5523342e252c68cf3560 100644

--- a/components/password_manager/core/common/credential_manager_types.h

+++ b/components/password_manager/core/common/credential_manager_types.h

@@ -12,6 +12,7 @@

#include "base/compiler_specific.h"

#include "base/strings/string16.h"

#include "url/gurl.h"

+#include "url/origin.h"

namespace autofill {

struct PasswordForm;

@@ -54,9 +55,8 @@ struct CredentialInfo {

// Corresponds to WebPasswordCredential's password property.

base::string16 password;

- // Corresponds to WebFederatedCredential's federation property, which is an

- // origin serialized as a URL (e.g. "https://example.com/").

- GURL federation;

+ // Corresponds to WebFederatedCredential's provider property.

+ url::Origin federation;

};

// Create a new autofill::PasswordForm object based on |info|, valid in the