components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc - Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc

Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: iOS2 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/save_password_infobar_delegate.cc ('K') | « components/autofill/core/common/password_form.cc ('k') | components/password_manager/content/common/credential_manager_content_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc

diff --git a/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc b/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc

index 8b9971645ab81529e89a073c712d8d2563bf6c4f..46d4aba51069b10d49d66e6ff727abdcc6461640 100644

--- a/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc

+++ b/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc

@@ -647,7 +647,7 @@ TEST_F(CredentialManagerDispatcherTest,

TEST_F(CredentialManagerDispatcherTest,

CredentialManagerOnRequestCredentialFederatedMatch) {

- form_.federation_url = GURL("https://example.com/");

+ form_.federation_origin = url::Origin(GURL("https://example.com/"));

store_->AddLogin(form_);

client_->set_first_run_seen(true);

@@ -662,7 +662,7 @@ TEST_F(CredentialManagerDispatcherTest,

TEST_F(CredentialManagerDispatcherTest,

CredentialManagerOnRequestCredentialFederatedNoMatch) {

- form_.federation_url = GURL("https://example.com/");

+ form_.federation_origin = url::Origin(GURL("https://example.com/"));

store_->AddLogin(form_);

client_->set_first_run_seen(true);

@@ -719,7 +719,8 @@ TEST_F(CredentialManagerDispatcherTest,

TEST_F(CredentialManagerDispatcherTest,

CredentialManagerOnRequestCredentialAffiliatedFederatedMatch) {

- affiliated_form1_.federation_url = GURL("https://example.com/");

+ affiliated_form1_.federation_origin =

+ url::Origin(GURL("https://example.com/"));

store_->AddLogin(affiliated_form1_);

client_->set_first_run_seen(true);

auto mock_helper = make_scoped_ptr(new MockAffiliatedMatchHelper);

@@ -741,7 +742,8 @@ TEST_F(CredentialManagerDispatcherTest,

TEST_F(CredentialManagerDispatcherTest,

CredentialManagerOnRequestCredentialAffiliatedFederatedNoMatch) {

- affiliated_form1_.federation_url = GURL("https://example.com/");

+ affiliated_form1_.federation_origin =

+ url::Origin(GURL("https://example.com/"));

store_->AddLogin(affiliated_form1_);

client_->set_first_run_seen(true);

auto mock_helper = make_scoped_ptr(new MockAffiliatedMatchHelper);