chrome/browser/ui/webui/options/password_manager_handler.cc - Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/password_manager_handler.cc

Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: iOS2 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/save_password_infobar_delegate.cc ('K') | « chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc ('k') | components/autofill/core/common/password_form.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/password_manager_handler.cc

diff --git a/chrome/browser/ui/webui/options/password_manager_handler.cc b/chrome/browser/ui/webui/options/password_manager_handler.cc

index 77256a75a4b64261adbeb47a2992a9b10e036f54..374e6e58cbb0ef2d542f7ce6e16df26bc80b1d5d 100644

--- a/chrome/browser/ui/webui/options/password_manager_handler.cc

+++ b/chrome/browser/ui/webui/options/password_manager_handler.cc

@@ -239,12 +239,12 @@ void PasswordManagerHandler::SetPasswordList(

kPasswordField,

base::string16(saved_password->password_value.length(), ' '));

}

- const GURL& federation_url = saved_password->federation_url;

- if (!federation_url.is_empty()) {

+ if (!saved_password->federation_origin.unique()) {

entry->SetString(

kFederationField,

- l10n_util::GetStringFUTF16(IDS_PASSWORDS_VIA_FEDERATION,

- base::UTF8ToUTF16(federation_url.host())));

+ l10n_util::GetStringFUTF16(

+ IDS_PASSWORDS_VIA_FEDERATION,

+ base::UTF8ToUTF16(saved_password->federation_origin.host())));

}

entries.Append(entry.release());