chrome/browser/ui/passwords/manage_passwords_state_unittest.cc - Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_state_unittest.cc

Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: iOS2 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/save_password_infobar_delegate.cc ('K') | « chrome/browser/ui/passwords/manage_passwords_state.cc ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_state_unittest.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc

index 1c8b56d41d614e84eae8290d1b2510ca62e367ed..5fd7eea856c03148b117e2758f9363d7cb2fb6a7 100644

--- a/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc

@@ -571,7 +571,7 @@ TEST_F(ManagePasswordsStateTest, ChooseCredentialLocalWithNonEmptyFederation) {

ScopedVector<autofill::PasswordForm>(),

test_local_form().origin);

autofill::PasswordForm form(test_federated_form());

- form.federation_url = GURL("https://federation.test/");

+ form.federation_origin = url::Origin(GURL("https://federation.test/"));

passwords_data().set_credentials_callback(base::Bind(

&ManagePasswordsStateTest::CredentialCallback, base::Unretained(this)));

password_manager::CredentialInfo credential_info(