chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc - Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc

Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: iOS2 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/password_manager/credential_android.cc » ('j') | chrome/browser/password_manager/save_password_infobar_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc

diff --git a/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc b/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc

index b9a05dbd17a4ebdcd6fb82cfc43560ded111f25d..09a3a9943bec911fabb17cbc4ae4f299f84822fb 100644

--- a/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc

+++ b/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc

@@ -171,11 +171,10 @@ void PasswordsPrivateDelegateImpl::SetPasswordList(

entry->login_pair.username = base::UTF16ToUTF8(form->username_value);

entry->num_characters_in_password = form->password_value.length();

- const GURL& federation_url = form->federation_url;

- if (!federation_url.is_empty()) {

+ if (!form->federation_origin.unique()) {

entry->federation_text.reset(new std::string(l10n_util::GetStringFUTF8(

IDS_PASSWORDS_VIA_FEDERATION,

- base::UTF8ToUTF16(federation_url.host_piece()))));

+ base::UTF8ToUTF16(form->federation_origin.host()))));

}

current_entries_.push_back(entry);

« no previous file with comments | « no previous file | chrome/browser/password_manager/credential_android.cc » ('j') | chrome/browser/password_manager/save_password_infobar_delegate.cc » ('J')