[NTP Snippets] Fetch/load snippets on startup, and pass them on NTP creation

chrome/browser/android/ntp_snippets_bridge.cc

Index: chrome/browser/android/ntp_snippets_bridge.cc
diff --git a/chrome/browser/android/ntp_snippets_bridge.cc b/chrome/browser/android/ntp_snippets_bridge.cc
index 1613ae42ccfc53b914c0580ad4808cf8d0968d2b..85aca7d98c06a594ead22cdf651b4b3d958bc534 100644
--- a/chrome/browser/android/ntp_snippets_bridge.cc
+++ b/chrome/browser/android/ntp_snippets_bridge.cc
@@ -23,22 +23,24 @@ using ntp_snippets::NTPSnippetsServiceObserver;
 
 static jlong Init(JNIEnv* env,
                   const JavaParamRef<jobject>& obj,
-                  const JavaParamRef<jobject>& j_profile,
-                  const JavaParamRef<jobject>& j_observer) {
-  NTPSnippetsBridge* snippets_bridge =
-      new NTPSnippetsBridge(env, j_profile, j_observer);
+                  const JavaParamRef<jobject>& j_profile) {
+  NTPSnippetsBridge* snippets_bridge = new NTPSnippetsBridge(env, j_profile);
   return reinterpret_cast<intptr_t>(snippets_bridge);
 }
 
-NTPSnippetsBridge::NTPSnippetsBridge(JNIEnv* env,
-                                     jobject j_profile,
-                                     jobject j_observer)
+NTPSnippetsBridge::NTPSnippetsBridge(JNIEnv* env, jobject j_profile)

[Bernhard Bauer, 2016/02/22 14:44:01]

All of these should be JavaParamRef<jobject>, BTW.

[Marc Treib, 2016/02/22 17:22:49]

Done. (Why don't we have some check for this?)

     : snippet_service_observer_(this) {
-  observer_.Reset(env, j_observer);
-
   Profile* profile = ProfileAndroid::FromProfileAndroid(j_profile);
   ntp_snippets_service_ = NTPSnippetsServiceFactory::GetForProfile(profile);
   snippet_service_observer_.Add(ntp_snippets_service_);
+}
+
+void NTPSnippetsBridge::SetObserver(
+    JNIEnv* env,
+    const base::android::JavaParamRef<jobject>& obj,
+    jobject j_observer) {
+  observer_.Reset(env, j_observer);
+
   if (ntp_snippets_service_->is_loaded())
     NTPSnippetsServiceLoaded(ntp_snippets_service_);
 }