[Interpreter] Textual representation for runtime function IDs.

[Interpreter] Readable representation of runtime function IDs.

The first operand to the CallRuntime class of bytecodes is the
ID of the runtime function being called. Before this commit
the ID was printed as plain uint16_t, now we get something like:

  B(CallRuntime) U16(Runtime::Add) ...

This change is intended to make both the golden files more
resistant to modifications of the i::Runtime::FunctionId enum
and the output of generate-bytecode-expectations more readable.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/bb2f68460e5dd8b04d1cc7b1d123fed39c221e20
Cr-Commit-Position: refs/heads/master@{#34224}

[Stefano Sanfilippo, 2016-02-23 17:13:33]

ssanfilippo@chromium.org changed reviewers:
+ oth@chromium.org, rmcilroy@chromium.org

[Stefano Sanfilippo, 2016-02-23 17:13:51]

Description was changed from

==========
[Interpreter] Textual representation for runtime function IDs.

The first operand to the CallRuntime class of bytecodes is the
ID of the runtime function being called. Before this commit
the ID was printed as uint16_t, now we get something like:

  B(CallRuntime) U16(Runtime::Add) ...

This change both makes the golden files more robust to
modifications of the i::Runtime::FunctionId enum and the output
of generate-bytecode-expectations more intelligible.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Textual representation for runtime function IDs.

The first operand to the CallRuntime class of bytecodes is the
ID of the runtime function being called. Before this commit
the ID was printed as plain uint16_t, now we get something like:

  B(CallRuntime) U16(Runtime::Add) ...

This change both makes the golden files more robust to
modifications of the i::Runtime::FunctionId enum and the output
of generate-bytecode-expectations more intelligible.

BUG=v8:4280
LOG=N
==========

[Stefano Sanfilippo, 2016-02-23 17:14:28]

Description was changed from

==========
[Interpreter] Textual representation for runtime function IDs.

The first operand to the CallRuntime class of bytecodes is the
ID of the runtime function being called. Before this commit
the ID was printed as plain uint16_t, now we get something like:

  B(CallRuntime) U16(Runtime::Add) ...

This change both makes the golden files more robust to
modifications of the i::Runtime::FunctionId enum and the output
of generate-bytecode-expectations more intelligible.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Readable representation of runtime function IDs.

The first operand to the CallRuntime class of bytecodes is the
ID of the runtime function being called. Before this commit
the ID was printed as plain uint16_t, now we get something like:

  B(CallRuntime) U16(Runtime::Add) ...

This change both makes the golden files more robust to
modifications of the i::Runtime::FunctionId enum and the output
of generate-bytecode-expectations more intelligible.

BUG=v8:4280
LOG=N
==========

[Stefano Sanfilippo, 2016-02-23 17:16:25]

The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 17:16:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1723223002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1723223002/1

[oth, 2016-02-23 17:37:15]

Thanks, very nice. lgtm with a pair of minor suggestions.

https://codereview.chromium.org/1723223002/diff/1/src/interpreter/bytecodes.h
File src/interpreter/bytecodes.h (right):

https://codereview.chromium.org/1723223002/diff/1/src/interpreter/bytecodes.h...
src/interpreter/bytecodes.h:481: // Returns true if the bytecode is a call to
runtime.
s/to runtime/to the runtime/

https://codereview.chromium.org/1723223002/diff/1/test/cctest/interpreter/byt...
File test/cctest/interpreter/bytecode-expectations-printer.cc (right):

https://codereview.chromium.org/1723223002/diff/1/test/cctest/interpreter/byt...
test/cctest/interpreter/bytecode-expectations-printer.cc:142: <<
i::Runtime::FunctionForId(
Nit - this is a bit dense with braces and brackets. It might be more readable to
put the index operand value into a variable before outputting to the stream or
have an inline helper function that converts op_index into an
i::Runtime::FunctionId.

[Stefano Sanfilippo, 2016-02-23 17:43:51]

https://codereview.chromium.org/1723223002/diff/1/src/interpreter/bytecodes.h
File src/interpreter/bytecodes.h (right):

https://codereview.chromium.org/1723223002/diff/1/src/interpreter/bytecodes.h...
src/interpreter/bytecodes.h:481: // Returns true if the bytecode is a call to
runtime.
On 2016/02/23 17:37:15, oth wrote:
> s/to runtime/to the runtime/

Done.

https://codereview.chromium.org/1723223002/diff/1/test/cctest/interpreter/byt...
File test/cctest/interpreter/bytecode-expectations-printer.cc (right):

https://codereview.chromium.org/1723223002/diff/1/test/cctest/interpreter/byt...
test/cctest/interpreter/bytecode-expectations-printer.cc:142: <<
i::Runtime::FunctionForId(
On 2016/02/23 17:37:15, oth wrote:
> Nit - this is a bit dense with braces and brackets. It might be more readable
to
> put the index operand value into a variable before outputting to the stream or
> have an inline helper function that converts op_index into an
> i::Runtime::FunctionId.

Done.

[Stefano Sanfilippo, 2016-02-23 17:44:25]

The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 17:44:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1723223002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1723223002/20001

[rmcilroy, 2016-02-23 17:53:23]

LGTM

https://codereview.chromium.org/1723223002/diff/20001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode-expectations-printer.cc (right):

https://codereview.chromium.org/1723223002/diff/20001/test/cctest/interpreter...
test/cctest/interpreter/bytecode-expectations-printer.cc:147: int operand =
bytecode_iter.GetIndexOperand(op_index);
Could you add a DCHECK here that op_index is a Idx16 operand type (to catch the
case if we add another call runtime function that doesn't put the id as the
first operand).

[Stefano Sanfilippo, 2016-02-23 17:59:24]

https://codereview.chromium.org/1723223002/diff/20001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode-expectations-printer.cc (right):

https://codereview.chromium.org/1723223002/diff/20001/test/cctest/interpreter...
test/cctest/interpreter/bytecode-expectations-printer.cc:147: int operand =
bytecode_iter.GetIndexOperand(op_index);
On 2016/02/23 17:53:23, rmcilroy wrote:
> Could you add a DCHECK here that op_index is a Idx16 operand type (to catch
the
> case if we add another call runtime function that doesn't put the id as the
> first operand).

Done.

[Stefano Sanfilippo, 2016-02-23 18:01:52]

The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 18:02:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1723223002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1723223002/40001

[Stefano Sanfilippo, 2016-02-23 18:30:07]

Description was changed from

==========
[Interpreter] Readable representation of runtime function IDs.

The first operand to the CallRuntime class of bytecodes is the
ID of the runtime function being called. Before this commit
the ID was printed as plain uint16_t, now we get something like:

  B(CallRuntime) U16(Runtime::Add) ...

This change both makes the golden files more robust to
modifications of the i::Runtime::FunctionId enum and the output
of generate-bytecode-expectations more intelligible.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Readable representation of runtime function IDs.

The first operand to the CallRuntime class of bytecodes is the
ID of the runtime function being called. Before this commit
the ID was printed as plain uint16_t, now we get something like:

  B(CallRuntime) U16(Runtime::Add) ...

This change both makes the golden files more resistant to
modifications of the i::Runtime::FunctionId enum and the output
of generate-bytecode-expectations more intelligible.

BUG=v8:4280
LOG=N
==========

[Stefano Sanfilippo, 2016-02-23 18:32:41]

Description was changed from

==========
[Interpreter] Readable representation of runtime function IDs.

The first operand to the CallRuntime class of bytecodes is the
ID of the runtime function being called. Before this commit
the ID was printed as plain uint16_t, now we get something like:

  B(CallRuntime) U16(Runtime::Add) ...

This change both makes the golden files more resistant to
modifications of the i::Runtime::FunctionId enum and the output
of generate-bytecode-expectations more intelligible.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Readable representation of runtime function IDs.

The first operand to the CallRuntime class of bytecodes is the
ID of the runtime function being called. Before this commit
the ID was printed as plain uint16_t, now we get something like:

  B(CallRuntime) U16(Runtime::Add) ...

This change is intended to make both the golden files more
resistant to modifications of the i::Runtime::FunctionId enum
and the output of generate-bytecode-expectations more readable.

BUG=v8:4280
LOG=N
==========

[commit-bot: I haz the power, 2016-02-23 19:03:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 19:03:51]

Dry run: This issue passed the CQ dry run.

[Stefano Sanfilippo, 2016-02-23 19:08:24]

The CQ bit was checked by ssanfilippo@chromium.org

[Stefano Sanfilippo, 2016-02-23 19:08:24]

The patchset sent to the CQ was uploaded after l-g-t-m from oth@chromium.org,
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1723223002/#ps40001
(title: "CallJSRuntime != CallRuntime, DCHECK op type, Runtime::k prefix.")

[commit-bot: I haz the power, 2016-02-23 19:08:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1723223002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1723223002/40001

[commit-bot: I haz the power, 2016-02-23 19:10:24]

Description was changed from

==========
[Interpreter] Readable representation of runtime function IDs.

The first operand to the CallRuntime class of bytecodes is the
ID of the runtime function being called. Before this commit
the ID was printed as plain uint16_t, now we get something like:

  B(CallRuntime) U16(Runtime::Add) ...

This change is intended to make both the golden files more
resistant to modifications of the i::Runtime::FunctionId enum
and the output of generate-bytecode-expectations more readable.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Readable representation of runtime function IDs.

The first operand to the CallRuntime class of bytecodes is the
ID of the runtime function being called. Before this commit
the ID was printed as plain uint16_t, now we get something like:

  B(CallRuntime) U16(Runtime::Add) ...

This change is intended to make both the golden files more
resistant to modifications of the i::Runtime::FunctionId enum
and the output of generate-bytecode-expectations more readable.

BUG=v8:4280
LOG=N
==========

[commit-bot: I haz the power, 2016-02-23 19:10:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-23 19:10:55]

Description was changed from

==========
[Interpreter] Readable representation of runtime function IDs.

The first operand to the CallRuntime class of bytecodes is the
ID of the runtime function being called. Before this commit
the ID was printed as plain uint16_t, now we get something like:

  B(CallRuntime) U16(Runtime::Add) ...

This change is intended to make both the golden files more
resistant to modifications of the i::Runtime::FunctionId enum
and the output of generate-bytecode-expectations more readable.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Readable representation of runtime function IDs.

The first operand to the CallRuntime class of bytecodes is the
ID of the runtime function being called. Before this commit
the ID was printed as plain uint16_t, now we get something like:

  B(CallRuntime) U16(Runtime::Add) ...

This change is intended to make both the golden files more
resistant to modifications of the i::Runtime::FunctionId enum
and the output of generate-bytecode-expectations more readable.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/bb2f68460e5dd8b04d1cc7b1d123fed39c221e20
Cr-Commit-Position: refs/heads/master@{#34224}
==========

[commit-bot: I haz the power, 2016-02-23 19:10:56]

Patchset 3 (id:??) landed as
https://crrev.com/bb2f68460e5dd8b04d1cc7b1d123fed39c221e20
Cr-Commit-Position: refs/heads/master@{#34224}