Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1723003002: Tear down v8 after pdf library is released (Closed)

Created:
4 years, 10 months ago by jun_fang
Modified:
4 years, 10 months ago
CC:
chromium-reviews, Jim Wang, kai_jing
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tear down v8 after pdf library is released BUG=pdfium:400 Committed: https://crrev.com/6b10bd89a2b570376444a154f3bb5352377fac4d Cr-Commit-Position: refs/heads/master@{#377030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pdf/pdfium/pdfium_engine.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
jun_fang
PTAL, thanks!
4 years, 10 months ago (2016-02-23 05:59:02 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2016-02-23 14:28:33 UTC) #3
Tom Sepez
lgtm
4 years, 10 months ago (2016-02-23 17:44:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723003002/1
4 years, 10 months ago (2016-02-23 17:45:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 18:54:45 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 18:56:00 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6b10bd89a2b570376444a154f3bb5352377fac4d
Cr-Commit-Position: refs/heads/master@{#377030}

Powered by Google App Engine
This is Rietveld 408576698