pdf/pdfium/pdfium_engine.cc - Issue 1723003002: Tear down v8 after pdf library is released

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/pdfium/pdfium_engine.cc

Issue 1723003002: Tear down v8 after pdf library is released (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pdf/pdfium/pdfium_engine.cc

diff --git a/pdf/pdfium/pdfium_engine.cc b/pdf/pdfium/pdfium_engine.cc

index 2b5921424ca89e69d74ba3be34b7698835c297bc..3899e0ee51eb3bf5278470fc2645cdee3e0e4752 100644

--- a/pdf/pdfium/pdfium_engine.cc

+++ b/pdf/pdfium/pdfium_engine.cc

@@ -518,8 +518,8 @@ bool InitializeSDK() {

}

void ShutdownSDK() {

- TearDownV8();

FPDF_DestroyLibrary();

+ TearDownV8();

}

PDFEngine* PDFEngine::Create(PDFEngine::Client* client) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »