Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1722893002: [LoaderTest] Add the gtest pretty printer for ResourceError (Closed)

Created:
4 years, 10 months ago by hiroshige
Modified:
4 years, 9 months ago
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp1274063003
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add the gtest pretty printer for ResourceError This will be used by https://codereview.chromium.org/1257343003/. This CL ignores a presubmit error: "Streams are highly discouraged. [readability/streams]" in PlatformTestPrinters.cpp. Because: std::ostream is required for gtest pretty printing. BUG=532364 Committed: https://crrev.com/f09dff4405b70b9b27fba049dd7cf59c2e585515 Cr-Commit-Position: refs/heads/master@{#381034}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Total comments: 8

Patch Set 5 : Rebase, reflect comments #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceError.h View 2 chunks +4 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/testing/PlatformTestPrinters.cpp View 1 2 3 4 1 chunk +30 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 45 (22 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722893002/1
4 years, 10 months ago (2016-02-23 02:13:48 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-23 03:35:58 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722893002/20001
4 years, 10 months ago (2016-02-25 19:16:58 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/179709)
4 years, 10 months ago (2016-02-25 21:20:11 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722893002/20001
4 years, 9 months ago (2016-02-26 23:29:51 UTC) #12
hiroshige
PTAL.
4 years, 9 months ago (2016-02-29 16:31:52 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722893002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722893002/40001
4 years, 9 months ago (2016-02-29 16:34:45 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 17:49:19 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722893002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722893002/60001
4 years, 9 months ago (2016-03-04 01:55:37 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/184014)
4 years, 9 months ago (2016-03-04 05:14:48 UTC) #21
tyoshino (SeeGerritForStatus)
lgtm https://codereview.chromium.org/1722893002/diff/60001/third_party/WebKit/Source/platform/testing/PlatformTestPrinters.cpp File third_party/WebKit/Source/platform/testing/PlatformTestPrinters.cpp (right): https://codereview.chromium.org/1722893002/diff/60001/third_party/WebKit/Source/platform/testing/PlatformTestPrinters.cpp#newcode1 third_party/WebKit/Source/platform/testing/PlatformTestPrinters.cpp:1: // Copyright 2015 The Chromium Authors. All rights ...
4 years, 9 months ago (2016-03-09 05:36:21 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722893002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722893002/80001
4 years, 9 months ago (2016-03-11 19:02:36 UTC) #24
hiroshige
https://codereview.chromium.org/1722893002/diff/60001/third_party/WebKit/Source/platform/testing/PlatformTestPrinters.cpp File third_party/WebKit/Source/platform/testing/PlatformTestPrinters.cpp (right): https://codereview.chromium.org/1722893002/diff/60001/third_party/WebKit/Source/platform/testing/PlatformTestPrinters.cpp#newcode1 third_party/WebKit/Source/platform/testing/PlatformTestPrinters.cpp:1: // Copyright 2015 The Chromium Authors. All rights reserved. ...
4 years, 9 months ago (2016-03-11 20:36:14 UTC) #25
hiroshige
mkwst@, could you take a look as a platform/ OWNER?
4 years, 9 months ago (2016-03-11 20:36:37 UTC) #27
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/188067)
4 years, 9 months ago (2016-03-11 22:57:49 UTC) #29
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722893002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722893002/100001
4 years, 9 months ago (2016-03-11 23:12:06 UTC) #31
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-12 04:39:07 UTC) #33
Mike West
LGTM.
4 years, 9 months ago (2016-03-14 10:37:52 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722893002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722893002/100001
4 years, 9 months ago (2016-03-14 15:08:29 UTC) #37
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/196207)
4 years, 9 months ago (2016-03-14 18:07:25 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722893002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722893002/100001
4 years, 9 months ago (2016-03-14 18:08:34 UTC) #41
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 9 months ago (2016-03-14 19:10:32 UTC) #43
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 19:12:06 UTC) #45
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/f09dff4405b70b9b27fba049dd7cf59c2e585515
Cr-Commit-Position: refs/heads/master@{#381034}

Powered by Google App Engine
This is Rietveld 408576698