|
|
DescriptionAdd the gtest pretty printer for ResourceError
This will be used by https://codereview.chromium.org/1257343003/.
This CL ignores a presubmit error:
"Streams are highly discouraged. [readability/streams]"
in PlatformTestPrinters.cpp.
Because:
std::ostream is required for gtest pretty printing.
BUG=532364
Committed: https://crrev.com/f09dff4405b70b9b27fba049dd7cf59c2e585515
Cr-Commit-Position: refs/heads/master@{#381034}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : Rebase. #Patch Set 4 : Rebase. #
Total comments: 8
Patch Set 5 : Rebase, reflect comments #Patch Set 6 : Rebase #
Dependent Patchsets: Messages
Total messages: 45 (22 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722893002/1
Description was changed from ========== Add the gtest pretty printer for ResourceError BUG= ========== to ========== Add the gtest pretty printer for ResourceError This will be used by https://codereview.chromium.org/1257343003/. This CL ignores a presubmit error: "Streams are highly discouraged. [readability/streams]" in PlatformTestPrinters.cpp. Because: std::ostream is required for gtest pretty printing. BUG=532364 ==========
hiroshige@chromium.org changed reviewers: + tyoshino@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722893002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722893002/20001
PTAL.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722893002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722893002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722893002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722893002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
lgtm https://codereview.chromium.org/1722893002/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/testing/PlatformTestPrinters.cpp (right): https://codereview.chromium.org/1722893002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/testing/PlatformTestPrinters.cpp:1: // Copyright 2015 The Chromium Authors. All rights reserved. 2016 https://codereview.chromium.org/1722893002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/testing/PlatformTestPrinters.cpp:5: #include "config.h" remove https://codereview.chromium.org/1722893002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/testing/PlatformTestPrinters.cpp:23: << ", localizedDescription = " << error.localizedDescription() isNull() is not included intentionally? https://codereview.chromium.org/1722893002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/testing/PlatformTestPrinters.cpp:31: } // namespace blink
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722893002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722893002/80001
https://codereview.chromium.org/1722893002/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/testing/PlatformTestPrinters.cpp (right): https://codereview.chromium.org/1722893002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/testing/PlatformTestPrinters.cpp:1: // Copyright 2015 The Chromium Authors. All rights reserved. On 2016/03/09 05:36:20, tyoshino wrote: > 2016 Done. https://codereview.chromium.org/1722893002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/testing/PlatformTestPrinters.cpp:5: #include "config.h" On 2016/03/09 05:36:21, tyoshino wrote: > remove Done. https://codereview.chromium.org/1722893002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/testing/PlatformTestPrinters.cpp:23: << ", localizedDescription = " << error.localizedDescription() On 2016/03/09 05:36:21, tyoshino wrote: > isNull() is not included intentionally? Added. https://codereview.chromium.org/1722893002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/testing/PlatformTestPrinters.cpp:31: } On 2016/03/09 05:36:21, tyoshino wrote: > // namespace blink Done.
hiroshige@chromium.org changed reviewers: + mkwst@chromium.org
mkwst@, could you take a look as a platform/ OWNER?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722893002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722893002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM.
The CQ bit was checked by hiroshige@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tyoshino@chromium.org Link to the patchset: https://codereview.chromium.org/1722893002/#ps100001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722893002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722893002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722893002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722893002/100001
Message was sent while issue was closed.
Description was changed from ========== Add the gtest pretty printer for ResourceError This will be used by https://codereview.chromium.org/1257343003/. This CL ignores a presubmit error: "Streams are highly discouraged. [readability/streams]" in PlatformTestPrinters.cpp. Because: std::ostream is required for gtest pretty printing. BUG=532364 ========== to ========== Add the gtest pretty printer for ResourceError This will be used by https://codereview.chromium.org/1257343003/. This CL ignores a presubmit error: "Streams are highly discouraged. [readability/streams]" in PlatformTestPrinters.cpp. Because: std::ostream is required for gtest pretty printing. BUG=532364 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Add the gtest pretty printer for ResourceError This will be used by https://codereview.chromium.org/1257343003/. This CL ignores a presubmit error: "Streams are highly discouraged. [readability/streams]" in PlatformTestPrinters.cpp. Because: std::ostream is required for gtest pretty printing. BUG=532364 ========== to ========== Add the gtest pretty printer for ResourceError This will be used by https://codereview.chromium.org/1257343003/. This CL ignores a presubmit error: "Streams are highly discouraged. [readability/streams]" in PlatformTestPrinters.cpp. Because: std::ostream is required for gtest pretty printing. BUG=532364 Committed: https://crrev.com/f09dff4405b70b9b27fba049dd7cf59c2e585515 Cr-Commit-Position: refs/heads/master@{#381034} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/f09dff4405b70b9b27fba049dd7cf59c2e585515 Cr-Commit-Position: refs/heads/master@{#381034} |