components/autofill/browser/autofill_external_delegate.cc - Issue 17225008: Eliminate AutofillExternalDelegate being a WebContentsUserData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/browser/autofill_external_delegate.cc

Issue 17225008: Eliminate AutofillExternalDelegate being a WebContentsUserData (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Response to review Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/browser/autofill_external_delegate.cc

diff --git a/components/autofill/browser/autofill_external_delegate.cc b/components/autofill/browser/autofill_external_delegate.cc

index d5ac726fb44f465fe6f92de4a748b3f5b2c9f2ff..a2d3cf76ad4751c7f60447e9d350e3855fde82b6 100644

--- a/components/autofill/browser/autofill_external_delegate.cc

+++ b/components/autofill/browser/autofill_external_delegate.cc

@@ -24,21 +24,8 @@

using content::RenderViewHost;

using WebKit::WebAutofillClient;

-DEFINE_WEB_CONTENTS_USER_DATA_KEY(autofill::AutofillExternalDelegate);

namespace autofill {

-void AutofillExternalDelegate::CreateForWebContentsAndManager(

- content::WebContents* web_contents,

- AutofillManager* autofill_manager) {

- if (FromWebContents(web_contents))

- return;

- web_contents->SetUserData(

- UserDataKey(),

- new AutofillExternalDelegate(web_contents, autofill_manager));

AutofillExternalDelegate::AutofillExternalDelegate(

content::WebContents* web_contents,

AutofillManager* autofill_manager)