Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(840)

Issue 17225008: Eliminate AutofillExternalDelegate being a WebContentsUserData (Closed)

Created:
4 years, 8 months ago by blundell
Modified:
4 years, 8 months ago
CC:
chromium-reviews, Raman Kakilate, benquan, jam, ahutter, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, selim, benm (inactive)
Visibility:
Public.

Description

Eliminate AutofillExternalDelegate being a WebContentsUserData This CL changes AutofillExternalDelegate from being a WebContentsUserData to being owned by AutofillDriverImpl as part of making Autofill a layered component. BUG=247015 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206967

Patch Set 1 #

Total comments: 13

Patch Set 2 : Response to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -51 lines) Patch
M chrome/browser/autofill/autofill_browsertest.cc View 4 chunks +13 lines, -8 lines 0 comments Download
M chrome/browser/autofill/autofill_interactive_uitest.cc View 3 chunks +13 lines, -10 lines 0 comments Download
M components/autofill/browser/autofill_external_delegate.h View 4 chunks +7 lines, -13 lines 0 comments Download
M components/autofill/browser/autofill_external_delegate.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M components/autofill/content/browser/autofill_driver_impl.h View 1 4 chunks +15 lines, -1 line 0 comments Download
M components/autofill/content/browser/autofill_driver_impl.cc View 1 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
blundell
https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.h File components/autofill/content/browser/autofill_driver_impl.h (right): https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.h#newcode42 components/autofill/content/browser/autofill_driver_impl.h:42: bool enable_native_ui); I looked at internalizing this parameter, but ...
4 years, 8 months ago (2013-06-17 15:14:37 UTC) #1
Ilya Sherman
LGTM % nits. Thanks! https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.cc File components/autofill/content/browser/autofill_driver_impl.cc (right): https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.cc#newcode61 components/autofill/content/browser/autofill_driver_impl.cc:61: new AutofillExternalDelegate(web_contents, &autofill_manager_))); nit: Reduce ...
4 years, 8 months ago (2013-06-17 21:25:12 UTC) #2
blundell
Thanks! Will address comments tomorrow, but just a quick question. https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.h File components/autofill/content/browser/autofill_driver_impl.h (right): https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.h#newcode55 ...
4 years, 8 months ago (2013-06-17 21:31:48 UTC) #3
Ilya Sherman
https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.h File components/autofill/content/browser/autofill_driver_impl.h (right): https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.h#newcode55 components/autofill/content/browser/autofill_driver_impl.h:55: scoped_ptr<AutofillExternalDelegate> delegate); Seems like tests should be able to ...
4 years, 8 months ago (2013-06-17 21:45:27 UTC) #4
blundell
Thanks! https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.cc File components/autofill/content/browser/autofill_driver_impl.cc (right): https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.cc#newcode61 components/autofill/content/browser/autofill_driver_impl.cc:61: new AutofillExternalDelegate(web_contents, &autofill_manager_))); This indentation of 4 spaces ...
4 years, 8 months ago (2013-06-18 06:20:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/17225008/14001
4 years, 8 months ago (2013-06-18 06:21:24 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2013-06-18 13:31:42 UTC) #7
Message was sent while issue was closed.
Change committed as 206967

Powered by Google App Engine
This is Rietveld 408576698