Chromium Code Reviews
Help | Chromium Project | Sign in
(620)

Issue 17225008: Eliminate AutofillExternalDelegate being a WebContentsUserData (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 months ago by blundell (OOO until April 28)
Modified:
10 months ago
CC:
chromium-reviews_chromium.org, Raman Kakilate, benquan, jam, ahutter, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, selim, benm
Visibility:
Public.

Description

Eliminate AutofillExternalDelegate being a WebContentsUserData

This CL changes AutofillExternalDelegate from being a WebContentsUserData to
being owned by AutofillDriverImpl as part of making Autofill a layered
component.

BUG=247015
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206967

Patch Set 1 #

Total comments: 13

Patch Set 2 : Response to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -51 lines) Lint Patch
M chrome/browser/autofill/autofill_browsertest.cc View 4 chunks +13 lines, -8 lines 0 comments 0 errors Download
M chrome/browser/autofill/autofill_interactive_uitest.cc View 3 chunks +13 lines, -10 lines 0 comments 0 errors Download
M components/autofill/browser/autofill_external_delegate.h View 4 chunks +7 lines, -13 lines 0 comments 0 errors Download
M components/autofill/browser/autofill_external_delegate.cc View 1 chunk +0 lines, -13 lines 0 comments 0 errors Download
M components/autofill/content/browser/autofill_driver_impl.h View 1 4 chunks +15 lines, -1 line 0 comments ? errors Download
M components/autofill/content/browser/autofill_driver_impl.cc View 1 2 chunks +8 lines, -6 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 7
blundell (OOO until April 28)
https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.h File components/autofill/content/browser/autofill_driver_impl.h (right): https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.h#newcode42 components/autofill/content/browser/autofill_driver_impl.h:42: bool enable_native_ui); I looked at internalizing this parameter, but ...
10 months ago #1
Ilya Sherman
LGTM % nits. Thanks! https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.cc File components/autofill/content/browser/autofill_driver_impl.cc (right): https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.cc#newcode61 components/autofill/content/browser/autofill_driver_impl.cc:61: new AutofillExternalDelegate(web_contents, &autofill_manager_))); nit: Reduce ...
10 months ago #2
blundell (OOO until April 28)
Thanks! Will address comments tomorrow, but just a quick question. https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.h File components/autofill/content/browser/autofill_driver_impl.h (right): https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.h#newcode55 ...
10 months ago #3
Ilya Sherman
https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.h File components/autofill/content/browser/autofill_driver_impl.h (right): https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.h#newcode55 components/autofill/content/browser/autofill_driver_impl.h:55: scoped_ptr<AutofillExternalDelegate> delegate); Seems like tests should be able to ...
10 months ago #4
blundell (OOO until April 28)
Thanks! https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.cc File components/autofill/content/browser/autofill_driver_impl.cc (right): https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.cc#newcode61 components/autofill/content/browser/autofill_driver_impl.cc:61: new AutofillExternalDelegate(web_contents, &autofill_manager_))); This indentation of 4 spaces ...
10 months ago #5
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/17225008/14001
10 months ago #6
I haz the power (commit-bot)
10 months ago #7
Message was sent while issue was closed.
Change committed as 206967
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434