Chromium Code Reviews
Help | Chromium Project | Sign in
(465)

Issue 17225008: Eliminate AutofillExternalDelegate being a WebContentsUserData (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by blundell
Modified:
2 years ago
CC:
chromium-reviews, Raman Kakilate, benquan, jam, ahutter, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman (Away July 8-13), rouslan+autofillwatch_chromium.org, selim, benm (inactive)
Visibility:
Public.

Description

Eliminate AutofillExternalDelegate being a WebContentsUserData This CL changes AutofillExternalDelegate from being a WebContentsUserData to being owned by AutofillDriverImpl as part of making Autofill a layered component. BUG=247015 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206967

Patch Set 1 #

Total comments: 13

Patch Set 2 : Response to review #

Messages

Total messages: 7 (0 generated)
blundell
https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.h File components/autofill/content/browser/autofill_driver_impl.h (right): https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.h#newcode42 components/autofill/content/browser/autofill_driver_impl.h:42: bool enable_native_ui); I looked at internalizing this parameter, but ...
2 years ago (2013-06-17 15:14:37 UTC) #1
Ilya Sherman (Away July 8-13)
LGTM % nits. Thanks! https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.cc File components/autofill/content/browser/autofill_driver_impl.cc (right): https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.cc#newcode61 components/autofill/content/browser/autofill_driver_impl.cc:61: new AutofillExternalDelegate(web_contents, &autofill_manager_))); nit: Reduce ...
2 years ago (2013-06-17 21:25:12 UTC) #2
blundell
Thanks! Will address comments tomorrow, but just a quick question. https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.h File components/autofill/content/browser/autofill_driver_impl.h (right): https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.h#newcode55 ...
2 years ago (2013-06-17 21:31:48 UTC) #3
Ilya Sherman (Away July 8-13)
https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.h File components/autofill/content/browser/autofill_driver_impl.h (right): https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.h#newcode55 components/autofill/content/browser/autofill_driver_impl.h:55: scoped_ptr<AutofillExternalDelegate> delegate); Seems like tests should be able to ...
2 years ago (2013-06-17 21:45:27 UTC) #4
blundell
Thanks! https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.cc File components/autofill/content/browser/autofill_driver_impl.cc (right): https://codereview.chromium.org/17225008/diff/1/components/autofill/content/browser/autofill_driver_impl.cc#newcode61 components/autofill/content/browser/autofill_driver_impl.cc:61: new AutofillExternalDelegate(web_contents, &autofill_manager_))); This indentation of 4 spaces ...
2 years ago (2013-06-18 06:20:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/17225008/14001
2 years ago (2013-06-18 06:21:24 UTC) #6
commit-bot: I haz the power
2 years ago (2013-06-18 13:31:42 UTC) #7
Message was sent while issue was closed.
Change committed as 206967
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1f9106d