Issue 17222004: Nuke OS::ReleaseStore, use Release_Store instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17222004: Nuke OS::ReleaseStore, use Release_Store instead (Closed)

Created:
7 years, 6 months ago by yurys

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Nuke OS::ReleaseStore, use Release_Store instead The operation is already implemented in atomicops.h No need to duplicate the code. BUG=None R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15218

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -55 lines)			Patch
M	src/platform.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	src/platform-cygwin.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/platform-freebsd.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/platform-linux.cc	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	src/platform-macos.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/platform-openbsd.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/platform-solaris.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/platform-win32.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/unbound-queue-inl.h	View	3 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Sven Panne

LGTM, but if I see things correctly, we should probably remove the BUG= line, because ...

7 years, 6 months ago (2013-06-18 07:11:53 UTC) #2

yurys

On 2013/06/18 07:11:53, Sven Panne wrote: > LGTM, but if I see things correctly, we ...

7 years, 6 months ago (2013-06-18 07:56:10 UTC) #3

yurys

7 years, 6 months ago (2013-06-20 06:16:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r15218 (presubmit successful).