Intel Power Gadget Lib Loader

This CL adds Intel Power Gadget Lib Loader to third_party.

BUG=337138
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252512

[Daniel Berlin, 2014-02-19 16:56:26]

LGTM from a license perspective.

[Pan, 2014-02-20 09:14:06]

Hi @brettw, @cpu, @darin.

could you please review this CL :)
thanks.
Pan

[brettw, 2014-02-20 23:26:37]

lgtm

[Pan, 2014-02-20 23:59:06]

The CQ bit was checked by pan.deng@intel.com

[commit-bot: I haz the power, 2014-02-21 00:00:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pan.deng@intel.com/172183002/1

[commit-bot: I haz the power, 2014-02-21 00:18:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-21 00:18:59]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Pan, 2014-02-21 02:31:42]

The CQ bit was checked by pan.deng@intel.com

[commit-bot: I haz the power, 2014-02-21 02:34:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pan.deng@intel.com/172183002/150001

[commit-bot: I haz the power, 2014-02-21 02:45:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-21 02:45:03]

Retried try job too often on win_rel for step(s) app_list_unittests,
ash_unittests, aura_unittests, base_unittests, browser_tests,
cacheinvalidation_unittests, cc_unittests, check_deps, check_deps2git,
chrome_elf_unittests, chromedriver_unittests, components_unittests,
compositor_unittests, content_browsertests, content_unittests, crypto_unittests,
events_unittests, google_apis_unittests, gpu_unittests,
installer_util_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
media_unittests, mini_installer_test, nacl_integration, net_unittests,
ppapi_unittests, printing_unittests, remoting_unittests, sql_unittests,
sync_integration_tests, sync_unit_tests, telemetry_perf_unittests,
telemetry_unittests, unit_tests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Pan, 2014-02-21 03:49:42]

The CQ bit was checked by pan.deng@intel.com

[commit-bot: I haz the power, 2014-02-21 03:49:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pan.deng@intel.com/172183002/150001

[commit-bot: I haz the power, 2014-02-21 04:38:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-21 04:38:01]

Retried try job too often on win_rel for step(s) net_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Pan, 2014-02-21 05:23:38]

The CQ bit was checked by pan.deng@intel.com

[commit-bot: I haz the power, 2014-02-21 05:24:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pan.deng@intel.com/172183002/150001

[commit-bot: I haz the power, 2014-02-21 06:36:02]

Change committed as 252512

[Nico, 2014-08-03 05:59:39]

https://codereview.chromium.org/172183002/diff/150001/third_party/power_gadge...
File third_party/power_gadget/PowerGadgetLib.h (right):

https://codereview.chromium.org/172183002/diff/150001/third_party/power_gadge...
third_party/power_gadget/PowerGadgetLib.h:33: using namespace std;
No using namespace statements in headers please.

..\..\third_party/power_gadget/PowerGadgetLib.h(33,17) :  warning(clang): using
namespace directive in global context in header [-Wheader-hygiene]
using namespace std;
                ^

Can you fix this?

[vivekg, 2014-08-06 04:43:51]

On 2014/08/03 05:59:39, Nico (very away) wrote:
>
https://codereview.chromium.org/172183002/diff/150001/third_party/power_gadge...
> File third_party/power_gadget/PowerGadgetLib.h (right):
> 
>
https://codereview.chromium.org/172183002/diff/150001/third_party/power_gadge...
> third_party/power_gadget/PowerGadgetLib.h:33: using namespace std;
> No using namespace statements in headers please.
> 
> ..\..\third_party/power_gadget/PowerGadgetLib.h(33,17) :  warning(clang):
using
> namespace directive in global context in header [-Wheader-hygiene]
> using namespace std;
>                 ^
> 
> Can you fix this?

Created a CL here to fix this: https://codereview.chromium.org/441083003

[Nico, 2014-08-06 04:50:11]

Pan: Is the source of this available somewhere on the Intel website, or did this
commit open-source that code and it's effectively hosted in the chromium repo?

[Pan, 2014-08-06 06:00:57]

On 2014/08/06 04:50:11, Nico (very away) wrote:
> Pan: Is the source of this available somewhere on the Intel website, or did
this
> commit open-source that code and it's effectively hosted in the chromium repo?

this CL committed Intel PowerGadget library "loader" rather than lib itself, it
is part of a application PowerLog which can be accessed
https://software.intel.com/en-us/blogs/2013/10/03/using-the-intel-power-gadge...,
and has been agreed to apply a BSD license.

thanks
Pan

[Nico, 2014-08-06 18:42:24]

On 2014/08/06 06:00:57, Pan wrote:
> On 2014/08/06 04:50:11, Nico (very away) wrote:
> > Pan: Is the source of this available somewhere on the Intel website, or did
> this
> > commit open-source that code and it's effectively hosted in the chromium
repo?
> 
> this CL committed Intel PowerGadget library "loader" rather than lib itself,
it
> is part of a application PowerLog which can be accessed
>
https://software.intel.com/en-us/blogs/2013/10/03/using-the-intel-power-gadge...,
> and has been agreed to apply a BSD license.

So the idea is that people will need to install the PowerLog application for the
DevTools power profiler to work?

[Pan, 2014-08-07 10:23:45]

On 2014/08/06 18:42:24, Nico (very away) wrote:
> On 2014/08/06 06:00:57, Pan wrote:
> > On 2014/08/06 04:50:11, Nico (very away) wrote:
> > > Pan: Is the source of this available somewhere on the Intel website, or
did
> > this
> > > commit open-source that code and it's effectively hosted in the chromium
> repo?
> > 
> > this CL committed Intel PowerGadget library "loader" rather than lib itself,
> it
> > is part of a application PowerLog which can be accessed
> >
>
https://software.intel.com/en-us/blogs/2013/10/03/using-the-intel-power-gadge...,
> > and has been agreed to apply a BSD license.
> 
> So the idea is that people will need to install the PowerLog application for
the
> DevTools power profiler to work?

Oh, it is not PowerLog, but PowerGadget, which contains PowerGadget Library. It
would be perfect if the lib can be installed together with browser,
unfortunately the library need a root promotion, so end user is expected to
install it. Without it installed, DevTools won't show up the power
functionality, this is the status for the time being.

Win PowerGadget library acts one of the power data provider, we also has OSX
library, but I don't have enough time to add it currently. These libs work
without external power measurement device, besides that, I think vivekg is
working on plumbing monsoon data.

thanks
Pan

[Nico, 2014-08-07 18:10:13]

On 2014/08/07 10:23:45, Pan wrote:
> On 2014/08/06 18:42:24, Nico (very away) wrote:
> > On 2014/08/06 06:00:57, Pan wrote:
> > > On 2014/08/06 04:50:11, Nico (very away) wrote:
> > > > Pan: Is the source of this available somewhere on the Intel website, or
> did
> > > this
> > > > commit open-source that code and it's effectively hosted in the chromium
> > repo?
> > > 
> > > this CL committed Intel PowerGadget library "loader" rather than lib
itself,
> > it
> > > is part of a application PowerLog which can be accessed
> > >
> >
>
https://software.intel.com/en-us/blogs/2013/10/03/using-the-intel-power-gadge...,
> > > and has been agreed to apply a BSD license.
> > 
> > So the idea is that people will need to install the PowerLog application for
> the
> > DevTools power profiler to work?
> 
> Oh, it is not PowerLog, but PowerGadget, which contains PowerGadget Library.
It
> would be perfect if the lib can be installed together with browser,

Is the PowerGadget library open source?

[Pan, 2014-08-08 06:21:05]

On 2014/08/07 18:10:13, Nico (very away) wrote:
> On 2014/08/07 10:23:45, Pan wrote:
> > On 2014/08/06 18:42:24, Nico (very away) wrote:
> > > On 2014/08/06 06:00:57, Pan wrote:
> > > > On 2014/08/06 04:50:11, Nico (very away) wrote:
> > > > > Pan: Is the source of this available somewhere on the Intel website,
or
> > did
> > > > this
> > > > > commit open-source that code and it's effectively hosted in the
chromium
> > > repo?
> > > > 
> > > > this CL committed Intel PowerGadget library "loader" rather than lib
> itself,
> > > it
> > > > is part of a application PowerLog which can be accessed
> > > >
> > >
> >
>
https://software.intel.com/en-us/blogs/2013/10/03/using-the-intel-power-gadge...,
> > > > and has been agreed to apply a BSD license.
> > > 
> > > So the idea is that people will need to install the PowerLog application
for
> > the
> > > DevTools power profiler to work?
> > 
> > Oh, it is not PowerLog, but PowerGadget, which contains PowerGadget Library.
> It
> > would be perfect if the lib can be installed together with browser,
> 
> Is the PowerGadget library open source?

no, it is not open source.

thanks
Pan