Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 441083003: Fix clang warning for 'using namespace std' in a header file: PowerGadgetLib.h (Closed)

Created:
6 years, 4 months ago by vivekg_samsung
Modified:
6 years, 4 months ago
Reviewers:
vivekg, brettw, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix clang warning for 'using namespace std' in a header file: PowerGadgetLib.h Removed the 'using namespace std' directive from the header with using qualified name for string as std::string. TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287758

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M third_party/power_gadget/PowerGadgetLib.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/power_gadget/PowerGadgetLib.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vivekg
Fixed the warning reported here https://codereview.chromium.org/172183002/#msg19
6 years, 4 months ago (2014-08-06 04:41:01 UTC) #1
Nico
lgtm, thanks Looks like there's no upstream repo, weird.
6 years, 4 months ago (2014-08-06 04:50:31 UTC) #2
vivekg
On 2014/08/06 04:50:31, Nico (very away) wrote: > lgtm, thanks > > Looks like there's ...
6 years, 4 months ago (2014-08-06 04:54:14 UTC) #3
Nico
On 2014/08/06 04:54:14, vivekg_ wrote: > On 2014/08/06 04:50:31, Nico (very away) wrote: > > ...
6 years, 4 months ago (2014-08-06 04:57:28 UTC) #4
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 4 months ago (2014-08-06 05:00:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/441083003/1
6 years, 4 months ago (2014-08-06 05:01:12 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 11:19:59 UTC) #7
Message was sent while issue was closed.
Change committed as 287758

Powered by Google App Engine
This is Rietveld 408576698