Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: content/public/browser/navigation_data.h

Issue 1721813002: Adding DRP specfic UMA for FirstContentfulPaint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Missing Header Include Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/navigation_data.h
diff --git a/content/public/browser/navigation_data.h b/content/public/browser/navigation_data.h
new file mode 100644
index 0000000000000000000000000000000000000000..b81d93813478e58dc04440b20b73250395ef0bbf
--- /dev/null
+++ b/content/public/browser/navigation_data.h
@@ -0,0 +1,28 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_DATA_H_
+#define CONTENT_PUBLIC_BROWSER_NAVIGATION_DATA_H_
+
+#include <memory>
+
+#include "base/macros.h"
bengr 2016/04/29 21:14:23 Why is this here? Did you mean to add DISALLOW_COP
RyanSturm 2016/05/02 19:52:22 Removing, each inheritor should deal with disallow
+
+namespace content {
+
+// Copyable interface for embedders to pass opaque data to content. It is
+// expected to be created on the IO thread, and content will transfer it to the
+// UI thread as a Clone.
bengr 2016/04/29 21:14:23 Clone -> clone
RyanSturm 2016/05/02 19:52:22 Done.
+class NavigationData {
+ public:
+ virtual ~NavigationData(){};
+
+ // Creates a new NavigationData that is a deep copy of the original, and
bengr 2016/04/29 21:14:23 is a -> is a "and could be used cross-thread" se
RyanSturm 2016/05/02 19:52:22 Done.
+ // could be used cross-thread.
+ virtual std::unique_ptr<NavigationData> Clone() const = 0;
+};
+
+} // namespace content
+
+#endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_DATA_H_

Powered by Google App Engine
This is Rietveld 408576698